thakis added a comment.
Looks like this breaks tests: http://45.33.8.238/linux/71327/step_9.txt
Please take a look and revert for now if it takes a while to fix
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116385/new/
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG1af5fbd5c605: [clangd] Code action for creating an ObjC
initializer (authored by dgoldman).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
dgoldman updated this revision to Diff 416186.
dgoldman marked 3 inline comments as done.
dgoldman added a comment.
Fixes for review
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116385/new/
https://reviews.llvm.org/D116385
Files:
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thanks, and sorry for the long delay.
Comment at:
clang-tools-extra/clangd/refactor/tweaks/ObjCMemberwiseInitializer.cpp:282
+ Anchor::Above}};
+
dgoldman added a comment.
Herald added a project: All.
friendly ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116385/new/
https://reviews.llvm.org/D116385
___
cfe-commits mailing list
dgoldman updated this revision to Diff 405765.
dgoldman added a comment.
mergingEdit --> manual file checks
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116385/new/
https://reviews.llvm.org/D116385
Files:
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/refactor/Tweak.h:85
+/// Merge the replacement's edit in the file corresponding to Loc.
+/// Fails if we cannot figure out the absolute path for the corresponding
I don't think
dgoldman added a comment.
PTAL, let me know what you think regarding the edits, had to make sure it works
even if we generate multiple edits in the same file.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116385/new/
dgoldman marked 3 inline comments as done.
dgoldman added inline comments.
Comment at:
clang-tools-extra/clangd/refactor/tweaks/ObjCMemberwiseInitializer.cpp:265
+ // Insert before the first non-init instance method.
+ std::vector Anchors = {
+ {[](const Decl *D) {
dgoldman updated this revision to Diff 397956.
dgoldman marked an inline comment as done.
dgoldman added a comment.
Support generating interface and impl
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116385/new/
https://reviews.llvm.org/D116385
sammccall added a comment.
Alright, the implementation looks good.
I think just a question of what to do when firing on @implementation. I'd
suggest one of:
- generating the interface too, you have almost allthe code
- not supporting @implementation yet
We can also keep the current behavior
dgoldman marked an inline comment as done.
dgoldman added inline comments.
Comment at:
clang-tools-extra/clangd/refactor/tweaks/ObjCMemberwiseInitializer.cpp:91
+
+struct LocationWithPadding {
+ SourceLocation Loc;
sammccall wrote:
> We try not to spend
dgoldman updated this revision to Diff 397329.
dgoldman marked 3 inline comments as done.
dgoldman added a comment.
Rebase + use new helpers
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116385/new/
https://reviews.llvm.org/D116385
Files:
dgoldman marked 3 inline comments as not done.
dgoldman added inline comments.
Comment at:
clang-tools-extra/clangd/refactor/tweaks/ObjCMemberwiseInitializer.cpp:113
+if (MD->getMethodFamily() == OMF_init) {
+ Loc = effectiveEndLoc(MD, SM).getLocWithOffset(1);
+}
dgoldman updated this revision to Diff 397321.
dgoldman marked 11 inline comments as done.
dgoldman added a comment.
Some review fixes, still need to rebase for new changes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116385/new/
sammccall added a comment.
This looks like a useful feature, I had been thinking about adding the
equivalent for C++...
High level feedback:
- this should generate both the declaration and definition
- i doubt the interaction around subsetting fields is going to be satisfying
- don't spend
dgoldman updated this revision to Diff 396706.
dgoldman added a comment.
Add another minor test case
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116385/new/
https://reviews.llvm.org/D116385
Files:
dgoldman updated this revision to Diff 396676.
dgoldman added a comment.
Minor change to how we get the loc of `@end`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116385/new/
https://reviews.llvm.org/D116385
Files:
dgoldman updated this revision to Diff 396569.
dgoldman added a comment.
Remove debug log statement
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116385/new/
https://reviews.llvm.org/D116385
Files:
dgoldman created this revision.
Herald added subscribers: usaxena95, kadircet, arphaman, mgorny.
dgoldman requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
The code action creates an initializer for the
20 matches
Mail list logo
