[PATCH] D116387: [CodeCompletion][clangd] Clean __uglified parameter names in completion & hover

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG33c3ef2fbeec: [CodeCompletion][clangd] Clean __uglified parameter names in completion hover (authored by sammccall). Repository: rG LLVM Github

[PATCH] D116387: [CodeCompletion][clangd] Clean __uglified parameter names in completion & hover

sammccall updated this revision to Diff 403149. sammccall marked an inline comment as done. sammccall added a comment. Fix hover revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116387/new/ https://reviews.llvm.org/D116387 Files:

[PATCH] D116387: [CodeCompletion][clangd] Clean __uglified parameter names in completion & hover

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:65 Base.SuppressTemplateArgsInCXXConstructors = true; + Base.CleanUglifiedParameters = true; return Base; hokein wrote: > IIUC, the

[PATCH] D116387: [CodeCompletion][clangd] Clean __uglified parameter names in completion & hover

hokein added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:65 Base.SuppressTemplateArgsInCXXConstructors = true; + Base.CleanUglifiedParameters = true; return Base; IIUC, the code looks like we change the hover behavior as well, but I

[PATCH] D116387: [CodeCompletion][clangd] Clean __uglified parameter names in completion & hover

sammccall updated this revision to Diff 398991. sammccall added a comment. Revert hover changes, only use for code complete Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116387/new/ https://reviews.llvm.org/D116387 Files:

[PATCH] D116387: [CodeCompletion][clangd] Clean __uglified parameter names in completion & hover

sammccall updated this revision to Diff 398779. sammccall added a comment. Fix printName Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116387/new/ https://reviews.llvm.org/D116387 Files: clang-tools-extra/clangd/AST.cpp

[PATCH] D116387: [CodeCompletion][clangd] Clean __uglified parameter names in completion & hover

sammccall added a comment. In D116387#3230893 , @hokein wrote: > Agree that __ reserved names are ugly, but I'm not sure this is a great > improvement. > > I played around the patch locally, and found the new behavior being confused > in some cases

[PATCH] D116387: [CodeCompletion][clangd] Clean __uglified parameter names in completion & hover

hokein added a comment. Agree that __ reserved names are ugly, but I'm not sure this is a great improvement. I played around the patch locally, and found the new behavior being confused in some cases (mostly inconsistencies between deuglified places vs uglified places), and seems hard for

[PATCH] D116387: [CodeCompletion][clangd] Clean __uglified parameter names in completion & hover

sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: dexonsmith, usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, clang-tools-extra.