[PATCH] D116488: Add a misc-unused-parameters.CommentOutUnusedParameters to clang-tidy

2022-01-04 Thread Jacques Pienaar via Phabricator via cfe-commits
jpienaar accepted this revision. jpienaar added a comment. This revision is now accepted and ready to land. Looks reasonable as an option/this is another way to make it explicit that param is unused. Comment at:

[PATCH] D116488: Add a misc-unused-parameters.CommentOutUnusedParameters to clang-tidy

2022-01-03 Thread Jeff Niu via Phabricator via cfe-commits
Mogball added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/UnusedParametersCheck.cpp:157 // will clean this up afterwards. -MyDiag << FixItHint::CreateReplacement( -RemovalRange, (Twine(" /*") + Param->getName() + "*/").str()); +if

[PATCH] D116488: Add a misc-unused-parameters.CommentOutUnusedParameters to clang-tidy

2022-01-02 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc-unused-parameters.rst:25 + + void a(int ) { /*some code that doesn't use `i`*/ } + jpienaar wrote: > OOC why the extra space after the type? The space is in the

[PATCH] D116488: Add a misc-unused-parameters.CommentOutUnusedParameters to clang-tidy

2022-01-02 Thread Jacques Pienaar via Phabricator via cfe-commits
jpienaar added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc-unused-parameters.rst:25 + + void a(int ) { /*some code that doesn't use `i`*/ } + OOC why the extra space after the type? Repository: rG LLVM Github Monorepo

[PATCH] D116488: Add a misc-unused-parameters.CommentOutUnusedParameters to clang-tidy

2022-01-01 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini created this revision. mehdi_amini added reviewers: rriddle, jpienaar, Mogball. Herald added a subscriber: carlosgalvezp. mehdi_amini requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This option allows to eliminate