[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG2c91754a13f3: [Clang] Add attributes alloc_size and alloc_align to mm_malloc (authored by xbolva00). Repository: rG

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117091/new/ https://reviews.llvm.org/D117091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 added a comment. Thanks! @jdoerfert ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117091/new/ https://reviews.llvm.org/D117091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 updated this revision to Diff 406583. xbolva00 added a comment. protect against user macros CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117091/new/ https://reviews.llvm.org/D117091 Files: clang/lib/Headers/mm_malloc.h clang/test/Headers/Inputs/include/malloc.h

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

aaron.ballman accepted this revision. aaron.ballman added a comment. The header bits LGTM aside from a nit I found with potential identifier conflicts. I don't feel super qualified to review the behavioral aspects of the change, but if others are happy with that, I'm happy with the header

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117091/new/ https://reviews.llvm.org/D117091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 added a comment. In D117091#3272589 , @aaron.ballman wrote: > There's a testing issue on Windows: > > TEST 'Clang :: Headers/mm_malloc.c' FAILED > > Script: > -- > : 'RUN: at line 1'; >

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 added a comment. In D117091#3272594 , @jdoerfert wrote: > Don't test with O1 , add the > dummy include folder to the include path > (`clang/test/Headers/Inputs/include`), stdlib.h is already there,

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 updated this revision to Diff 404397. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117091/new/ https://reviews.llvm.org/D117091 Files: clang/lib/Headers/mm_malloc.h clang/test/Headers/Inputs/include/malloc.h clang/test/Headers/mm_malloc.c Index:

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 updated this revision to Diff 404395. xbolva00 added a comment. Added newline CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117091/new/ https://reviews.llvm.org/D117091 Files: clang/lib/Headers/mm_malloc.h clang/test/Headers/Inputs/include/malloc.h

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 updated this revision to Diff 404394. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117091/new/ https://reviews.llvm.org/D117091 Files: clang/lib/Headers/mm_malloc.h clang/test/Headers/Inputs/include/malloc.h clang/test/Headers/mm_malloc.c Index:

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 updated this revision to Diff 404393. xbolva00 added a comment. Herald added a subscriber: mstorsjo. Address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117091/new/ https://reviews.llvm.org/D117091 Files: clang/lib/Headers/mm_malloc.h

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

jdoerfert requested changes to this revision. jdoerfert added a comment. This revision now requires changes to proceed. Don't test with O1 , add the dummy include folder to the include path (`clang/test/Headers/Inputs/include`), stdlib.h is already

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

aaron.ballman added a comment. There's a testing issue on Windows: TEST 'Clang :: Headers/mm_malloc.c' FAILED Script: -- : 'RUN: at line 1'; c:\ws\w2\llvm-project\premerge-checks\build\bin\clang.exe -emit-llvm -std=c11 -x c

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 added a comment. In D117091#3267980 , @reames wrote: > In D117091#3265986 , @xbolva00 > wrote: > >> Ping @reames > > Not qualified to review clang/c++ library semantic changes. > > Also, did we

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

reames added a comment. In D117091#3265986 , @xbolva00 wrote: > Ping @reames Not qualified to review clang/c++ library semantic changes. Also, did we implement allocalign in LLVM? Last I knew it was a clang only attribute. If we did, it's missing

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 added a comment. Ping @reames CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117091/new/ https://reviews.llvm.org/D117091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 updated this revision to Diff 402207. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117091/new/ https://reviews.llvm.org/D117091 Files: clang/lib/Headers/mm_malloc.h clang/test/Headers/mm_malloc.c Index: clang/test/Headers/mm_malloc.c

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 updated this revision to Diff 402206. xbolva00 added a comment. Added testcase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117091/new/ https://reviews.llvm.org/D117091 Files: clang/lib/Headers/mm_malloc.h clang/test/Headers/mm_malloc.c Index:

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 added a comment. Yes, test for alignment should be possible, something like _Bool alig_test(void) { // CHECK: ret i1 true yvoid *p = _mm_malloc(2014, 16); _Bool ret = ((__SIZE_TYPE__)p % 16) == 0; _mm_free(p); return ret; } For alloc size not sure how..

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

fhahn added a comment. Not really familiar with testing for clang headers. Is it possible to test the new attributes have the desired effect? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117091/new/ https://reviews.llvm.org/D117091

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 created this revision. xbolva00 added reviewers: reames, rjmccall, jdoerfert. xbolva00 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. alloc align https://clang.llvm.org/docs/AttributeReference.html#alloc-align alloc size