This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGce16ca3c7419: [OpenMP] Add support for linking AMDGPU images
(authored by jhuber6).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
tianshilei1992 added a comment.
@JonChesterfield can we just accept the patch and make it in 14? If we later
find anything broken, we could have bug fix.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117246/new/
https://reviews.llvm.org/D117246
jhuber6 updated this revision to Diff 402929.
jhuber6 added a comment.
Update commits.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117246/new/
https://reviews.llvm.org/D117246
Files:
clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
jhuber6 updated this revision to Diff 401466.
jhuber6 added a comment.
Updating after upstreaming a portion of this patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117246/new/
https://reviews.llvm.org/D117246
Files:
jhuber6 added inline comments.
Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp:297
+
+std::string Arch = DAL->getLastArgValue(options::OPT_march_EQ).str();
+if (Arch.empty()) {
JonChesterfield wrote:
> This part is valuable as-is and probably
JonChesterfield added a comment.
A bit nervous about the automatic appending of host library search paths for
the device link but I see that's pre-existing in nvptx. I'll check whether -###
changes behaviour as expected and approve if it does
Comment at:
jhuber6 created this revision.
jhuber6 added reviewers: jdoerfert, gregrodgers, JonChesterfield, ronlieb.
Herald added subscribers: kerbowa, guansong, t-tye, tpr, dstuttard, yaxunl,
nhaehnle, jvesely, kzhuravl.
jhuber6 requested review of this revision.
Herald added subscribers: cfe-commits,
