[PATCH] D117460: [clang-tidy][NFC] Reduce map lookups in IncludeSorter

PiotrZSL added a comment. This change is dangerous, it depends that elements/iterators won't be re-allocated/invalidated during insertion process. Part with removing double lookup in IncludeSorter::addInclude looks fine, but part that involve IncludeBucket is problematic. I will try to push

[PATCH] D117460: [clang-tidy][NFC] Reduce map lookups in IncludeSorter

LegalizeAdulthood added a comment. Herald added a project: All. Are we waiting on some sort of benchmark before accepting/rejecting this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117460/new/ https://reviews.llvm.org/D117460

[PATCH] D117460: [clang-tidy][NFC] Reduce map lookups in IncludeSorter

njames93 added a comment. In D117460#3248613 , @alexfh wrote: > I wonder what motivated the patch. Is this a performance optimization? If so, > do you have any measurements? I was doing some work on IncludeInserter and just thought, this seems

[PATCH] D117460: [clang-tidy][NFC] Reduce map lookups in IncludeSorter

alexfh added a comment. I wonder what motivated the patch. Is this a performance optimization? If so, do you have any measurements? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117460/new/ https://reviews.llvm.org/D117460

[PATCH] D117460: [clang-tidy][NFC] Reduce map lookups in IncludeSorter

njames93 created this revision. njames93 added reviewers: LegalizeAdulthood, alexfh, aaron.ballman. Herald added subscribers: carlosgalvezp, xazax.hun. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Because