sgatev added a comment.
@gribozavr2 suggested that this is probably because we use delayed template
parsing on Windows for MSVC compatibility. I reproduced the error using the
`--target=x86_64-windows-msvc` arg and verified that adding
`-fno-delayed-template-parsing` arg fixes it.
sgatev added a comment.
Thanks for sharing this. I reverted the patch and will look at why it fails on
Windows.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117567/new/
https://reviews.llvm.org/D117567
thakis added a comment.
This breaks tests on windows: http://45.33.8.238/win/52841/step_7.txt
Please take a look and revert for now if it takes a while to fix.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117567/new/
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG68226e572f41: [clang][dataflow] Add a test to justify
skipping past references in UO_Deref (authored by sgatev).
Repository:
rG LLVM Github
sgatev added a comment.
I also think that we should prefer checking instantiations. We have a single
Clang-Tidy check that works on templates and I believe this is the only special
support that it needs. We can revisit that later and remove this support if it
proves to be unnecessary.
xazax.hun added a comment.
Is it planned to support templated code this way?
I'm not entirely sure if this is worth pursuing as opposed to checking
instantiations.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117567/new/
sgatev created this revision.
sgatev added reviewers: ymandel, xazax.hun, gribozavr2.
Herald added subscribers: steakhal, rnkovacs.
sgatev requested review of this revision.
Herald added a project: clang.
This is part of the implementation of the dataflow analysis framework.
See "[RFC] A dataflow
