This revision was automatically updated to reflect the committed changes.
Closed by commit rG280b43031ca0: [Analyzer] Add docs to
StdCLibraryFunctionArgsChecker (authored by martong).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117568/new/
steakhal accepted this revision.
steakhal added a comment.
Looks great.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117568/new/
https://reviews.llvm.org/D117568
___
cfe-commits mailing list
martong added inline comments.
Comment at: clang/docs/analyzer/checkers.rst:2361
+(void)ret;
+clang_analyzer_eval(EOF <= x && x <= 255); // this reports TRUE
+ }
NoQ wrote:
> I recommend against using `clang_analyzer_eval` in user docs. Users aren't
>
martong updated this revision to Diff 401230.
martong marked 3 inline comments as done.
martong added a comment.
- Describe the different kind of constraints and limitations
- Some rewording
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117568/new/
dkrupp added inline comments.
Comment at: clang/docs/analyzer/checkers.rst:2371
+diagnostics) for functions that are defined in the POSIX standard. This option
+is disabled by default.
+
I think it would be useful for the user to see one example per constraint
steakhal added a comment.
I like it. Terse but complete.
I think you could polish the example code to look less synthetic.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117568/new/
https://reviews.llvm.org/D117568
NoQ added inline comments.
Comment at: clang/docs/analyzer/checkers.rst:2361
+(void)ret;
+clang_analyzer_eval(EOF <= x && x <= 255); // this reports TRUE
+ }
I recommend against using `clang_analyzer_eval` in user docs. Users aren't
expected to know
martong created this revision.
martong added reviewers: steakhal, gamesh411, NoQ.
Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus,
mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun.
Herald added a reviewer: Szelethus.
martong requested
