This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd224be3b999a: [RISCV] Add the policy operand for some masked
RVV ternary IR intrinsics. (authored by khchen).
Changed prior to commit:
https://rev
craig.topper added a comment.
LGTM
Note, I don't think vslidedown needs a tail policy, but vslideup does. But
probably not worth making them different.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117681/new/
https://reviews.llvm.org/D117681
__
khchen added a comment.
Gentle ping.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117681/new/
https://reviews.llvm.org/D117681
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.
khchen updated this revision to Diff 403117.
khchen added a comment.
rebase and address Craig's comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117681/new/
https://reviews.llvm.org/D117681
Files:
clang/include/clang/Basic/riscv_vector.td
craig.topper added inline comments.
Herald added a subscriber: pcwang-thead.
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:2342
defm _VS : VPseudoTernary,
- Sched<[WriteVIRedV, ReadVIRedV, ReadVIRedV, ReadVIRedV,
ReadVMask]>;
+ Sche
khchen updated this revision to Diff 401447.
khchen added a comment.
Address Craig's comment. Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117681/new/
https://reviews.llvm.org/D117681
Files:
clang/include/clang/Basic/riscv_vector.td
c
craig.topper added inline comments.
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:2187
+multiclass VPseudoTernaryNoMaskNoPolicyhttps://reviews.llvm.org/D117681/new/
https://reviews.llvm.org/D117681
___
cfe-commits mailin
khchen created this revision.
khchen added reviewers: craig.topper, rogfer01, frasercrmck, kito-cheng,
arcbbb, monkchiang.
Herald added subscribers: VincentWu, luke957, achieveartificialintelligence,
vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna,
psnobl, jocewei, PkmX