[PATCH] D117744: [Driver] Remove obsoleted -gz=zlib-gnu

MaskRay added a comment. In D117744#3275226 , @labath wrote: > This (unsurprisingly) broke an lldb test for the gnu style compression. You > didn't get the notification because the bot was already red at the time. I've > already fixed the situation by

[PATCH] D117744: [Driver] Remove obsoleted -gz=zlib-gnu

labath added a comment. This (unsurprisingly) broke an lldb test for the gnu style compression. You didn't get the notification because the bot was already red at the time. I've already fixed the situation by converting the test to yaml, but I thought you may want to know what happened.

[PATCH] D117744: [Driver] Remove obsoleted -gz=zlib-gnu

This revision was automatically updated to reflect the committed changes. Closed by commit rG35d15222c05d: [Driver] Remove obsoleted -gz=zlib-gnu (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D117744?vs=401498=403395#toc Repository: rG LLVM Github Monorepo

[PATCH] D117744: [Driver] Remove obsoleted -gz=zlib-gnu

MaskRay added a comment. In D117744#3273521 , @dblaikie wrote: > In D117744#3273481 , @MaskRay wrote: > >> In D117744#3273463 , @dblaikie >> wrote: >> >>> I don't

[PATCH] D117744: [Driver] Remove obsoleted -gz=zlib-gnu

dblaikie added a comment. In D117744#3273481 , @MaskRay wrote: > In D117744#3273463 , @dblaikie > wrote: > >> I don't especially feel that removing low-cost features like this is a great >> idea (the benefit to

[PATCH] D117744: [Driver] Remove obsoleted -gz=zlib-gnu

MaskRay added a comment. In D117744#3273463 , @dblaikie wrote: > I don't especially feel that removing low-cost features like this is a great > idea (the benefit to cleaning up a small amount of code compared to the > (albeit small) risk of breaking

[PATCH] D117744: [Driver] Remove obsoleted -gz=zlib-gnu

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. I don't especially feel that removing low-cost features like this is a great idea (the benefit to cleaning up a small amount of code compared to the (albeit small) risk of breaking users

[PATCH] D117744: [Driver] Remove obsoleted -gz=zlib-gnu

MaskRay added a comment. Ping:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117744/new/ https://reviews.llvm.org/D117744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D117744: [Driver] Remove obsoleted -gz=zlib-gnu

MaskRay added a comment. In D117744#3259305 , @dblaikie wrote: >> According to Debian Code Search, no project uses -gz=zlib-gnu (valgrind has >> a configure to use -gz=zlib) > > Could you link to the queries you used to validate this? I'd be curious to

[PATCH] D117744: [Driver] Remove obsoleted -gz=zlib-gnu

dblaikie added a comment. > According to Debian Code Search, no project uses -gz=zlib-gnu (valgrind has a > configure to use -gz=zlib) Could you link to the queries you used to validate this? I'd be curious to take a look around. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D117744: [Driver] Remove obsoleted -gz=zlib-gnu

MaskRay updated this revision to Diff 401498. MaskRay added a comment. fix a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117744/new/ https://reviews.llvm.org/D117744 Files: clang/include/clang/Driver/Options.td

[PATCH] D117744: [Driver] Remove obsoleted -gz=zlib-gnu

MaskRay created this revision. MaskRay added reviewers: compnerd, yaxunl. Herald added subscribers: dang, jvesely. Herald added a reviewer: ctetreau. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. GCC added -gz=zlib-gnu in 2014