[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

fhahn added a comment. > @fhahn Remind me - why did you want me to split these? If we're initially > just going for integer support, can't both be done at the same time in this > patch? I think my original thinking was that `__builtin_reduce_mul` isn't defined at the moment https://clang.llvm.

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

RKSimon added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117829/new/ https://reviews.llvm.org/D117829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

RKSimon updated this revision to Diff 421556. RKSimon added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117829/new/ https://reviews.llvm.org/D117829 Files: clang/include/clang/Basic/Builtins.def clang/lib/CodeGen/CGBuiltin.

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

RKSimon added a comment. Herald added a subscriber: StephenFan. @fhahn Remind me - why did you want me to split these? If we're initially just going for integer support, can't both be done at the same time in this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

fhahn added a comment. In D117829#3389241 , @RKSimon wrote: > In D117829#3386398 , @fhahn wrote: > >> @RKSimon are you planning on pushing this patch through? From my >> perspective, it looks good with splitting

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

RKSimon added a comment. In D117829#3386398 , @fhahn wrote: > @RKSimon are you planning on pushing this patch through? From my perspective, > it looks good with splitting off `__builtin_reduce_mul` and adding a TODO to > also implement it for floating p

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

fhahn added a comment. Herald added a project: All. @RKSimon are you planning on pushing this patch through? From my perspective, it looks good with splitting off `__builtin_reduce_mul` and adding a TODO to also implement it for floating point types. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

junaire added a comment. > @junaire has been looking into this and put up D117480 > as an option to extend the intrinsic to > have a dedicated order argument. Hi @fhahn, I wonder if we should continue working on this as I remember one of the reviewers was dou

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

fhahn added a comment. In D117829#3260772 , @RKSimon wrote: > I'm happy to continue with this just for integers or wait until we have a > plan for floats as well. I guess we need to decide if we want to support the > starting value in the fadd/fmul intr

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

RKSimon added a comment. I'm happy to continue with this just for integers or wait until we have a plan for floats as well. I guess we need to decide if we want to support the starting value in the fadd/fmul intrinsics from the builtin or not? If we don't then adding float support to the add/mu

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

fhahn added a subscriber: junaire. fhahn added a comment. Thanks for the patch! > For other reductions, we've tried to share builtins for float/integer > vectors, but the fadd/fmul reduction builtins also take a starting value > argument. Technically I could support float by using default value

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

craig.topper added a comment. In D117829#3259588 , @RKSimon wrote: > I should mention - according to > https://clang.llvm.org/docs/LanguageExtensions.html `__builtin_reduce_add()` > already exists, which I don't think is true. Does that documentation n

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

RKSimon added a comment. I should mention - according to https://clang.llvm.org/docs/LanguageExtensions.html `__builtin_reduce_add()` already exists, which I don't think is true. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117829/new/ https://r

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

RKSimon created this revision. RKSimon added reviewers: fhahn, scanon, aaron.ballman, craig.topper. RKSimon requested review of this revision. Herald added a project: clang. Similar to the existing bitwise reduction builtins, these are lowered to the llvm.vector.reduce.add/mul intrinsic calls. F