[PATCH] D117881: [X86] Remove avx512f integer and/or/xor/min/max reduction intrinsics and use generic equivalents

2022-01-24 Thread Simon Pilgrim via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe4074432d5bf: [X86] Remove avx512f integer and/or/xor/min/max reduction intrinsics and useā€¦ (authored by RKSimon). Repository: rG LLVM Github

[PATCH] D117881: [X86] Remove avx512f integer and/or/xor/min/max reduction intrinsics and use generic equivalents

2022-01-22 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei accepted this revision. pengfei added a comment. I see. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117881/new/ https://reviews.llvm.org/D117881 ___ cfe-commits mailing list

[PATCH] D117881: [X86] Remove avx512f integer and/or/xor/min/max reduction intrinsics and use generic equivalents

2022-01-22 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added a comment. In D117881#3263152 , @pengfei wrote: > What's the difference between `__builtin_reduce_and` and generating a > `Intrinsic::vector_reduce_and` in code? If this is just a simplification, why > can't be applied to `add` too?

[PATCH] D117881: [X86] Remove avx512f integer and/or/xor/min/max reduction intrinsics and use generic equivalents

2022-01-21 Thread Craig Topper via Phabricator via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117881/new/ https://reviews.llvm.org/D117881

[PATCH] D117881: [X86] Remove avx512f integer and/or/xor/min/max reduction intrinsics and use generic equivalents

2022-01-21 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. In D117881#3263152 , @pengfei wrote: > What's the difference between `__builtin_reduce_and` and generating a > `Intrinsic::vector_reduce_and` in code? If this is just a simplification, why > can't be applied to `add` too?

[PATCH] D117881: [X86] Remove avx512f integer and/or/xor/min/max reduction intrinsics and use generic equivalents

2022-01-21 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei added a comment. What's the difference between `__builtin_reduce_and` and generating a `Intrinsic::vector_reduce_and` in code? If this is just a simplification, why can't be applied to `add` too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D117881: [X86] Remove avx512f integer and/or/xor/min/max reduction intrinsics and use generic equivalents

2022-01-21 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon created this revision. RKSimon added reviewers: pengfei, craig.topper, fhahn. RKSimon requested review of this revision. Herald added a project: clang. None of these have any reordering issues, and they still emit the same reduction intrinsics without any change in the existing test