[PATCH] D117898: [Clang] Add elementwise saturated add/sub builtins

2022-02-08 Thread Simon Pilgrim via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc00db9715975: [Clang] Add elementwise saturated add/sub builtins (authored by RKSimon). Changed prior to commit: https://reviews.llvm.org/D117898?vs=406264=406756#toc Repository: rG LLVM Github

[PATCH] D117898: [Clang] Add elementwise saturated add/sub builtins

2022-02-07 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/docs/LanguageExtensions.rst:549 + T __builtin_elementwise_add_sat(T x, T y) return the sum of x and y, clamped to the range of signed or integer types + values representable by

[PATCH] D117898: [Clang] Add elementwise saturated add/sub builtins

2022-02-07 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added inline comments. Comment at: clang/docs/LanguageExtensions.rst:549 + T __builtin_elementwise_add_sat(T x, T y) return the sum of x and y, clamped to the range of signed or integer types + values representable by the

[PATCH] D117898: [Clang] Add elementwise saturated add/sub builtins

2022-02-07 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from some nits, this LGTM. Comment at: clang/docs/LanguageExtensions.rst:549 + T __builtin_elementwise_add_sat(T x, T y) return the sum of x and y,

[PATCH] D117898: [Clang] Add elementwise saturated add/sub builtins

2022-02-06 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon updated this revision to Diff 406264. RKSimon added a comment. rebase, simplify description in documentation and add _BitInt test coverage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117898/new/ https://reviews.llvm.org/D117898 Files:

[PATCH] D117898: [Clang] Add elementwise saturated add/sub builtins

2022-01-28 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/docs/LanguageExtensions.rst:549 + T __builtin_elementwise_add_sat(T x, T y) return the sum of x and y, clamped to the range of signed or integer types + values representable by

[PATCH] D117898: [Clang] Add elementwise saturated add/sub builtins

2022-01-28 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon updated this revision to Diff 404013. RKSimon added a comment. rebase and add signed/unsigned integer mismatch tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117898/new/ https://reviews.llvm.org/D117898 Files:

[PATCH] D117898: [Clang] Add elementwise saturated add/sub builtins

2022-01-28 Thread Florian Hahn via Phabricator via cfe-commits
fhahn added inline comments. Comment at: clang/test/CodeGen/builtins-elementwise-math.c:117 + // CHECK-NEXT: call <4 x i32> @llvm.usub.sat.v4i32(<4 x i32> [[VU1]], <4 x i32> [[VU2]]) + vu1 = __builtin_elementwise_sub_sat(vu1, vu2); + It might be good to have

[PATCH] D117898: [Clang] Add elementwise saturated add/sub builtins

2022-01-27 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117898/new/ https://reviews.llvm.org/D117898 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D117898: [Clang] Add elementwise saturated add/sub builtins

2022-01-23 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon updated this revision to Diff 402313. RKSimon added a comment. address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117898/new/ https://reviews.llvm.org/D117898 Files: clang/docs/LanguageExtensions.rst

[PATCH] D117898: [Clang] Add elementwise saturated add/sub builtins

2022-01-21 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: clang/docs/LanguageExtensions.rst:549 + T __builtin_elementwise_add_sat(T x, T y) return the sum of x and y, clamped to the range of signed or integer types + values representable by

[PATCH] D117898: [Clang] Add elementwise saturated add/sub builtins

2022-01-21 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon created this revision. RKSimon added reviewers: fhahn, aaron.ballman, scanon, craig.topper. Herald added subscribers: pengfei, sunfish, kristof.beyls, dschuff. RKSimon requested review of this revision. Herald added a subscriber: aheejin. Herald added a project: clang. This patch