This revision was automatically updated to reflect the committed changes.
Closed by commit rL268366: [libclang] Expose the ElaboratedType (authored by
skalinichev).
Changed prior to commit:
http://reviews.llvm.org/D11797?vs=51109=55953#toc
Repository:
rL LLVM
http://reviews.llvm.org/D11797
skalinichev added a comment.
Ok, If there are no objections, I'll commit this revision next week then.
http://reviews.llvm.org/D11797
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
skalinichev updated this revision to Diff 51109.
skalinichev added a comment.
Looking a bit more at the recent commits in libclang, it seems like all
recently added functions follow this naming convention:
clang_Cursor_*
clang_Type_*
e.t.c.
So I'm renaming the function to follow that style
kfunk added inline comments.
Comment at: tools/libclang/CXType.cpp:990
@@ -987,1 +989,3 @@
+CXType clang_getNamedTypeUnderlyingElaboratedType(CXType CT){
+ QualType T = GetQualType(CT);
I'm not happy with this name either. If you look through the libclang API,
skalinichev updated the summary for this revision.
skalinichev added reviewers: milianw, kfunk.
skalinichev updated this revision to Diff 50027.
skalinichev added a comment.
Ok, after some more testing I found out that elaborated types can have cv
specifiers attached, but after using
klimek added a comment.
Ok, so just for my understanding: the nested name specifier in the changed
tests canonicaltype is *not* the user-written type (thus, what the elaborated
type would get us), but the full nested name specifier of the canonical type?
http://reviews.llvm.org/D11797
skalinichev updated this revision to Diff 34350.
skalinichev added a comment.
Yes, I've noticed that inconsistency too. But, seems like, this is an unrelated
issue: TemplateSpecializationType type for some reasons uses id instead of qid
(See also all other tests with templates in
skalinichev updated this revision to Diff 34019.
skalinichev added a comment.
Rebased.
Yes, now it's ready.
http://reviews.llvm.org/D11797
Files:
test/Index/print-type.c
test/Index/print-type.cpp
tools/libclang/CXType.cpp
Index: tools/libclang/CXType.cpp
klimek added a subscriber: klimek.
klimek added a comment.
Is this still ready for submission or do you want to change something (not
clear after your last comment :)
http://reviews.llvm.org/D11797
___
cfe-commits mailing list
