eopXD added inline comments.
Comment at: clang/include/clang/Basic/riscv_vector.td:180
+ // The nomask intrinsic IR have the passthru operand.
+ bit HasNoMaskPassThru = false;
eopXD wrote:
> Nit: V-spec prefers to call instructions without masking operands
eopXD added inline comments.
Comment at: clang/include/clang/Basic/riscv_vector.td:180
+ // The nomask intrinsic IR have the passthru operand.
+ bit HasNoMaskPassThru = false;
Nit: V-spec prefers to call instructions without masking operands "unmasked
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb7847199044e: [RISCV] Add the passthru operand for RVV
nomask binary intrinsics. (authored by khchen).
Herald added a subscriber: qcolombet.
craig.topper added a comment.
LGTM other than what I think is an unnecessary include.
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:15
#include "RISCVISelLowering.h"
+#include "MCTargetDesc/RISCVBaseInfo.h"
#include "MCTargetDesc/RISCVMatInt.h"
craig.topper added inline comments.
Comment at: clang/include/clang/Basic/riscv_vector.td:181
+ // The nomask intrinsic IR have the passthru operand.
+ bit HasNoMaskPolicy = false;
+
Should this be `HasNoMaskPassThru` rather than `Policy`?
khchen added a comment.
Gentle ping.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117989/new/
https://reviews.llvm.org/D117989
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
craig.topper added inline comments.
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:4503
case Intrinsic::riscv_vslide1down_mask: {
// We need to special case these when the scalar is larger than XLen.
unsigned NumOps = Op.getNumOperands();
rogfer01 accepted this revision.
rogfer01 added a comment.
This revision is now accepted and ready to land.
Looks reasonable to me. Thans @khchen!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117989/new/
https://reviews.llvm.org/D117989
