[PATCH] D118011: [RISCV] Adjust predicates and update intrinsic for clmul and clmulh in Zbkc extension

craig.topper added inline comments. Comment at: clang/include/clang/Basic/BuiltinsRISCV.def:28 +// Zbkc extension +TARGET_BUILTIN(__builtin_riscv_clmul_kc, "LiLiLi", "nc", "zbkc") +TARGET_BUILTIN(__builtin_riscv_clmulh_kc, "LiLiLi", "nc", "zbkc") After D117854,

[PATCH] D118011: [RISCV] Adjust predicates and update intrinsic for clmul and clmulh in Zbkc extension

craig.topper added a comment. In D118011#3266014 , @alextsao1999 wrote: > In D118011#3265374 , @Jimerlife > wrote: > >> In D118011#3265071 , @craig.topper >> wrote: >>

[PATCH] D118011: [RISCV] Adjust predicates and update intrinsic for clmul and clmulh in Zbkc extension

VincentWu added a comment. Hi, Jimerlife it is a great work to implement the intrinsic of `zbkb`. however, I don't know whether you have noticed that there is already to patch https://reviews.llvm.org/D112774 and https://reviews.llvm.org/D102310. these two patches have included almost all the

[PATCH] D118011: [RISCV] Adjust predicates and update intrinsic for clmul and clmulh in Zbkc extension

alextsao1999 added a comment. In D118011#3265374 , @Jimerlife wrote: > In D118011#3265071 , @craig.topper > wrote: > >> Will you also be updating clang's RISCVBuiltins.def? >> >> Can you add tests? > > I update

[PATCH] D118011: [RISCV] Adjust predicates and update intrinsic for clmul and clmulh in Zbkc extension

liaolucy added a comment. clang Zbkc patch: https://reviews.llvm.org/D112774， If there are any mistakes, you can help to point them out Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118011/new/ https://reviews.llvm.org/D118011

[PATCH] D118011: [RISCV] Adjust predicates and update intrinsic for clmul and clmulh in Zbkc extension

Jimerlife updated this revision to Diff 402426. Jimerlife added a comment. add spaces around "or" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118011/new/ https://reviews.llvm.org/D118011 Files: clang/include/clang/Basic/BuiltinsRISCV.def

[PATCH] D118011: [RISCV] Adjust predicates and update intrinsic for clmul and clmulh in Zbkc extension

craig.topper added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsRISCV.td:91 - // Zbc + // ZbcorZbkc def int_riscv_clmul : BitManipGPRGPRIntrinsics; Add spaces around “or” Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D118011: [RISCV] Adjust predicates and update intrinsic for clmul and clmulh in Zbkc extension

Jimerlife added a comment. In D118011#3265069 , @kito-cheng wrote: > Actually this patch is NOT NFC, you fixed an issue that is: `zbkc` isn't > include `cmul` and `clmulh`. > > So I would suggest you: > > 1. Remove NFC from the title. > 2. Add test

[PATCH] D118011: [RISCV] Adjust predicates and update intrinsic for clmul and clmulh in Zbkc extension

Jimerlife added a comment. In D118011#3265071 , @craig.topper wrote: > Will you also be updating clang's RISCVBuiltins.def? > > Can you add tests? I update BuiltinsRISCV.def and add "__builtin_riscv_clmul_kc" intrinsic for zbkc extension, but I am not

[PATCH] D118011: [RISCV] Adjust predicates and update intrinsic for clmul and clmulh in Zbkc extension

Jimerlife updated this revision to Diff 402414. Jimerlife retitled this revision from "[RISCV][NFC] Add "zbkc" predicate for clmul and clmulh pattern" to "[RISCV] Adjust predicates and update intrinsic for clmul and clmulh in Zbkc extension ". Jimerlife edited the summary of this revision.