[PATCH] D118052: [X86] Fix CodeGen Module Flag for -mibt-seal

pengfei added a comment. In D118052#3480564 , @joaomoreira wrote: > I think there are no more untied knots... @pengfei, do you think this is > ready to merge? If yes, can you please merge it? tks! Sure. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D118052: [X86] Fix CodeGen Module Flag for -mibt-seal

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb1cec371c00: [X86] Fix CodeGen Module Flag for -mibt-seal (authored by joaomoreira, committed by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D118052: [X86] Fix CodeGen Module Flag for -mibt-seal

joaomoreira added a comment. I think there are no more untied knots... @pengfei, do you think this is ready to merge? If yes, can you please merge it? tks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118052/new/ https://reviews.llvm.org/D118052

[PATCH] D118052: [X86] Fix CodeGen Module Flag for -mibt-seal

joaomoreira updated this revision to Diff 423775. This revision is now accepted and ready to land. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118052/new/ https://reviews.llvm.org/D118052 Files: clang/lib/Frontend/CompilerInvocation.cpp clang/test/CodeGen/X86/x86-cf-protection.c

[PATCH] D118052: [X86] Fix CodeGen Module Flag for -mibt-seal

joaomoreira added inline comments. Comment at: clang/test/CodeGen/X86/x86-cf-protection.c:4 // RUN: %clang -target i386-unknown-unknown -x c -E -dM -o - -fcf-protection=full %s | FileCheck %s --check-prefix=FULL +// RUN: %clang -target i386-unknown-unknown -o - -emit-llvm -S

[PATCH] D118052: [X86] Fix CodeGen Module Flag for -mibt-seal

xiangzhangllvm added inline comments. Comment at: clang/test/CodeGen/X86/x86-cf-protection.c:4 // RUN: %clang -target i386-unknown-unknown -x c -E -dM -o - -fcf-protection=full %s | FileCheck %s --check-prefix=FULL +// RUN: %clang -target i386-unknown-unknown -o - -emit-llvm

[PATCH] D118052: [X86] Fix CodeGen Module Flag for -mibt-seal

nickdesaulniers added inline comments. Comment at: clang/test/CodeGen/X86/x86-cf-protection.c:5-16 +// RUN: %clang -target i386-unknown-unknown -o - -emit-llvm -S -fcf-protection=branch -flto %s | FileCheck %s --check-prefix=NOIBTSEAL +// RUN: %clang -target

[PATCH] D118052: [X86] Fix CodeGen Module Flag for -mibt-seal

aaron.ballman added a comment. In D118052#3401861 , @joaomoreira wrote: > I did track down the problem to clang/lib/Frontend/CompilerInvocation.cpp -- > RoundTrip method. There, we can se the following statement: > > #ifndef NDEBUG > bool

[PATCH] D118052: [X86] Fix CodeGen Module Flag for -mibt-seal

pengfei accepted this revision. pengfei added a comment. LGTM. Comment at: clang/test/CodeGen/X86/x86-cf-protection.c:6 +// RUN: %clang -target i386-unknown-unknown -o - -emit-llvm -S -fcf-protection=branch -flto %s | FileCheck %s --check-prefix=NOIBTSEAL +// RUN: %clang

[PATCH] D118052: [X86] Fix CodeGen Module Flag for -mibt-seal

joaomoreira updated this revision to Diff 417539. joaomoreira edited the summary of this revision. joaomoreira added a reviewer: nickdesaulniers. This revision is now accepted and ready to land. Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D118052: [X86] Fix CodeGen Module Flag for -mibt-seal

joaomoreira added a comment. I did track down the problem to clang/lib/Frontend/CompilerInvocation.cpp -- RoundTrip method. There, we can se the following statement: #ifndef NDEBUG bool DoRoundTripDefault = true; #else bool DoRoundTripDefault = false; #endif Comment in the file

[PATCH] D118052: [X86] Fix CodeGen Module Flag for -mibt-seal

joaomoreira planned changes to this revision. joaomoreira added inline comments. Herald added a project: All. Comment at: clang/test/CodeGen/X86/x86-cf-protection.c:4 // RUN: %clang -target i386-unknown-unknown -x c -E -dM -o - -fcf-protection=full %s | FileCheck %s

[PATCH] D118052: [X86] Fix CodeGen Module Flag for -mibt-seal

aaron.ballman added subscribers: cfe-commits, aaron.ballman. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. In D118052#3273241 , @gftg wrote: > Thanks, João, that's exactly what I needed. For the record, the use of >