[PATCH] D118110: [CMake] [Clang] Add CMake build option to specify long double format on PowerPC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb797d5e6b21b: [CMake] [Clang] Add option to specify PowerPC long double format (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D118110: [CMake] [Clang] Add CMake build option to specify long double format on PowerPC

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118110/new/ https://reviews.llvm.org/D118110

[PATCH] D118110: [CMake] [Clang] Add CMake build option to specify long double format on PowerPC

qiucf added a comment. > It is probably not worth the effort since there won't be that many test cases > that test the front end's IR generation for long double, but there should be > a way to set up lit to know the default through its configuration files. Yes, lit doesn't know about it. But

[PATCH] D118110: [CMake] [Clang] Add CMake build option to specify long double format on PowerPC

qiucf updated this revision to Diff 403114. qiucf marked 3 inline comments as done. qiucf edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118110/new/ https://reviews.llvm.org/D118110 Files: clang/CMakeLists.txt

[PATCH] D118110: [CMake] [Clang] Add CMake build option to specify long double format on PowerPC

jsji added a comment. In D118110#3269450 , @nemanjai wrote: > It is probably not worth the effort since there won't be that many test cases > that test the front end's IR generation for `long double`, but there should > be a way to set up lit to know

[PATCH] D118110: [CMake] [Clang] Add CMake build option to specify long double format on PowerPC

nemanjai added inline comments. Comment at: clang/CMakeLists.txt:240 +set(ENABLE_PPC_IEEELONGDOUBLE OFF CACHE BOOL +"Enable IEEE binary128 as default long double format on PowerPC.") Do we need any error checking here? What happens if someone erroneously

[PATCH] D118110: [CMake] [Clang] Add CMake build option to specify long double format on PowerPC

nemanjai added a comment. It is probably not worth the effort since there won't be that many test cases that test the front end's IR generation for `long double`, but there should be a way to set up lit to know the default through its configuration files. Repository: rG LLVM Github Monorepo

[PATCH] D118110: [CMake] [Clang] Add CMake build option to specify long double format on PowerPC

qiucf created this revision. qiucf added reviewers: jsji, nemanjai, shchenz, PowerPC. Herald added subscribers: steven.zhang, kbarton, mgorny. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This method introduces new CMake variable