[PATCH] D118259: [AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL

kpn added a comment. In D118259#3389246 , @fhahn wrote: > In D118259#3389235 , @kpn wrote: > >> It's been a while, but I think the aarch64-neon-intrinsics-constrained.c >> test is trimmed down from the aarch64-ne

[PATCH] D118259: [AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL

fhahn added a comment. In D118259#3389235 , @kpn wrote: > It's been a while, but I think the aarch64-neon-intrinsics-constrained.c test > is trimmed down from the aarch64-neon-intrinsics.c test. Shouldn't the > constrained and non-constrained end-to-end

[PATCH] D118259: [AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL

kpn added a comment. It's been a while, but I think the aarch64-neon-intrinsics-constrained.c test is trimmed down from the aarch64-neon-intrinsics.c test. Shouldn't the constrained and non-constrained end-to-end tests be treated the same? Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D118259: [AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL

john.brawn added a comment. llvm/test/CodeGen/AArch64/fp-intrinsics-vector.ll is testing the asm generation, so it probably is fine to remove that here so I will. This test is specifically testing arm_neon.h intrinsics though, so wouldn't make sense unifying with other architectures. Reposito

[PATCH] D118259: [AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL

fhahn added a comment. In D118259#3343554 , @john.brawn wrote: > In D118259#3275297 , @fhahn wrote: > >> Does this clang test actually need to check the generated assembly? >> Shouldn't it be enough to check tha

[PATCH] D118259: [AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL

john.brawn added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118259/new/ https://reviews.llvm.org/D118259 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D118259: [AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL

john.brawn added a comment. Herald added a project: All. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118259/new/ https://reviews.llvm.org/D118259 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D118259: [AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL

john.brawn added a comment. In D118259#3275297 , @fhahn wrote: > Does this clang test actually need to check the generated assembly? Shouldn't > it be enough to check that the correct intrinsics are generated? I could remove the CHECK-ASM checks, but th

[PATCH] D118259: [AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL

fhahn added a comment. Does this clang test actually need to check the generated assembly? Shouldn't it be enough to check that the correct intrinsics are generated? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118259/new/ https://reviews.llvm.or

[PATCH] D118259: [AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL

john.brawn created this revision. john.brawn added reviewers: kpn, cameron.mcinally, dmgreen, t.p.northover. Herald added a subscriber: kristof.beyls. john.brawn requested review of this revision. Herald added a project: clang. This test no longer fails during isel, but does need the expected outp