This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG36622c4e1a48: [clang-format] Fix
AllowShortFunctionsOnASingleLine: InlineOnly with wrapping… (authored by
curdeius).
Repository:
rG LLVM Github
HazardyKnusperkeks accepted this revision.
HazardyKnusperkeks added a comment.
+1 for the TokenAnnotatorTests, I think we need more of those instead of
testing the formatted output.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118337/new/
lichray added a comment.
Looks nice, and works for me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118337/new/
https://reviews.llvm.org/D118337
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
curdeius added inline comments.
Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:280
+if (Style.isJavaScript() && (*I)->Last->is(TT_FunctionLBrace))
+ return true;
+
MyDeveloperDay wrote:
> we didn't need this anymore?
Before it
MyDeveloperDay added inline comments.
Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:280
+if (Style.isJavaScript() && (*I)->Last->is(TT_FunctionLBrace))
+ return true;
+
we didn't need this anymore?
Repository:
rG LLVM
curdeius created this revision.
curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan.
curdeius requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Fixes https://github.com/llvm/llvm-project/issues/53430.
Initially, I had a
