[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

ChuanqiXu added a comment. In D118352#3371425 , @h-vetinari wrote: > Something must have gone wrong... communication-wise... as @urnathan seems to > have abandoned (resp. resigned from) all modules PRs. Hope any > misunderstandings or grievances can

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

h-vetinari added a comment. Something must have gone wrong... communication-wise... as @urnathan seems to have abandoned (resp. resigned from) all modules PRs. Hope any misunderstandings or grievances can be worked out! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

steven_wu added a comment. In D118352#3368922 , @ChuanqiXu wrote: > In D118352#3368919 , @phosek wrote: > >> We're also seeing this issue on our Mac bots, is it possible to revert it? > > I've reverted it. Since

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

ChuanqiXu added a comment. In D118352#3368919 , @phosek wrote: > We're also seeing this issue on our Mac bots, is it possible to revert it? I've reverted it. Since this is the new feature, I think it wouldn't so hurry to land it. BTW, I think it would

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

phosek added a comment. We're also seeing this issue on our Mac bots, is it possible to revert it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118352/new/ https://reviews.llvm.org/D118352 ___

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

thakis added a comment. (also, please don't land unused code -- land those functions when you land their callers) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118352/new/ https://reviews.llvm.org/D118352

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

thakis added a comment. Looks like this breaks tests on macOS: http://45.33.8.238/macm1/29650/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118352/new/

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

This revision was automatically updated to reflect the committed changes. Closed by commit rG21e16ab6b8dd: [clang][ABI] New C++20 module mangling scheme (authored by urnathan). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM, then. BTW, I see there is already no dependency with D119833 in code. But it shows dependency still in phab. CHANGES SINCE LAST ACTION

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

iains added a comment. In D118352#3363909 , @urnathan wrote: > In D118352#3362694 , @ChuanqiXu > wrote: > >> In D118352#3359626 , @urnathan >> wrote: >> >>> > > > >>>

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

urnathan added a comment. In D118352#3362694 , @ChuanqiXu wrote: > In D118352#3359626 , @urnathan > wrote: > >> >> Correct, it is not called as the global initializer pieces are not yet >> implemented.

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

urnathan updated this revision to Diff 413472. urnathan added a comment. added partition tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118352/new/ https://reviews.llvm.org/D118352 Files: clang/include/clang/AST/Mangle.h clang/lib/AST/Decl.cpp

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

ChuanqiXu added a comment. In D118352#3359626 , @urnathan wrote: > In D118352#3358864 , @ChuanqiXu > wrote: > >> If I don't misread the codes, it looks like `mangleModuleInitializer` is not >> called. > > > >>

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

urnathan added a comment. In D118352#3358864 , @ChuanqiXu wrote: > If I don't misread the codes, it looks like `mangleModuleInitializer` is not > called. > Now we could add test for partitions. Correct, it is not called as the global initializer

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

ChuanqiXu added a comment. If I don't misread the codes, it looks like `mangleModuleInitializer` is not called. --- Now we could add test for partitions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118352/new/ https://reviews.llvm.org/D118352

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

urnathan updated this revision to Diff 412669. urnathan added a comment. Herald added a project: All. Updated to new partitions API CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118352/new/ https://reviews.llvm.org/D118352 Files: clang/include/clang/AST/Mangle.h

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

ChuanqiXu added a comment. @urnathan FWIW, D114714 is landed~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118352/new/ https://reviews.llvm.org/D118352 ___ cfe-commits mailing list

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

urnathan added a comment. In D118352#3331396 , @ChuanqiXu wrote: > Thanks for explanation. Now it looks good to me. Let's accept it formally > after the series of partition landed and so that we could add test about > partitions. thanks, We're going

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

ChuanqiXu added a comment. Thanks for explanation. Now it looks good to me. Let's accept it formally after the series of partition landed and so that we could add test about partitions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118352/new/ https://reviews.llvm.org/D118352

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

urnathan updated this revision to Diff 409761. urnathan added a subscriber: cfe-commits. urnathan added a comment. rebase on top of D116773 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118352/new/ https://reviews.llvm.org/D118352 Files: