xiangzhangllvm added inline comments.
Comment at: llvm/lib/Target/X86/X86IndirectBranchTracking.cpp:156-161
if (needsPrologueENDBR(MF, M)) {
-auto MBB = MF.begin();
-Changed |= addENDBR(*MBB, MBB->begin());
+if (!ManualENDBR || MF.getFunction().doesCfCheck()) {
+
joaomoreira added inline comments.
Comment at: llvm/lib/Target/X86/X86IndirectBranchTracking.cpp:156-161
if (needsPrologueENDBR(MF, M)) {
-auto MBB = MF.begin();
-Changed |= addENDBR(*MBB, MBB->begin());
+if (!ManualENDBR || MF.getFunction().doesCfCheck()) {
+
xiangzhangllvm added inline comments.
Comment at: llvm/lib/Target/X86/X86IndirectBranchTracking.cpp:156-161
if (needsPrologueENDBR(MF, M)) {
-auto MBB = MF.begin();
-Changed |= addENDBR(*MBB, MBB->begin());
+if (!ManualENDBR || MF.getFunction().doesCfCheck()) {
+
gftg added a comment.
This patch as-is doesn't build. To build it needs another change that I know is
wrong, so I'm posting it below to ask for your help:
[RFC] How to add more bits to the Type class?
After reading https://reviews.llvm.org/D50630, I learned that keeping
the
gftg created this revision.
gftg added reviewers: xiangzhangllvm, pengfei, erichkeane, joaomoreira.
Herald added subscribers: ormris, dexonsmith, dang, jdoerfert, steven_wu,
martong, hiraditya.
Herald added a reviewer: aaron.ballman.
gftg requested review of this revision.
Herald added projects:
