[PATCH] D118385: [NFC] Optimize FoldingSet usage where it matters

yurai007 added a comment. In D118385#3281620 , @nikic wrote: > It might make sense to split this into individual changes, so it's clearer > what impact each of them has. > > I tested just moving the `AddXYZ` methods into the header, which had a large >

[PATCH] D118385: [NFC] Optimize FoldingSet usage where it matters

nikic added a comment. It might make sense to split this into individual changes, so it's clearer what impact each of them has. I tested just moving the `AddXYZ` methods into the header, which had a large positive impact:

[PATCH] D118385: [NFC] Optimize FoldingSet usage where it matters

yurai007 added inline comments. Comment at: llvm/include/llvm/ADT/FoldingSet.h:328 /// Add* - Add various data types to Bit data. - void AddPointer(const void *Ptr); - void AddInteger(signed I); - void AddInteger(unsigned I); - void AddInteger(long I); - void

[PATCH] D118385: [NFC] Optimize FoldingSet usage where it matters

serge-sans-paille added inline comments. Comment at: llvm/include/llvm/ADT/FoldingSet.h:328 /// Add* - Add various data types to Bit data. - void AddPointer(const void *Ptr); - void AddInteger(signed I); - void AddInteger(unsigned I); - void AddInteger(long I); - void

[PATCH] D118385: [NFC] Optimize FoldingSet usage where it matters

xbolva00 added inline comments. Comment at: llvm/include/llvm/ADT/FoldingSet.h:328 /// Add* - Add various data types to Bit data. - void AddPointer(const void *Ptr); - void AddInteger(signed I); - void AddInteger(unsigned I); - void AddInteger(long I); - void

[PATCH] D118385: [NFC] Optimize FoldingSet usage where it matters

yurai007 marked 3 inline comments as done. yurai007 added inline comments. Comment at: llvm/include/llvm/ADT/FoldingSet.h:328 /// Add* - Add various data types to Bit data. - void AddPointer(const void *Ptr); - void AddInteger(signed I); - void AddInteger(unsigned I); -

[PATCH] D118385: [NFC] Optimize FoldingSet usage where it matters

yurai007 updated this revision to Diff 403951. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118385/new/ https://reviews.llvm.org/D118385 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTContext.cpp

[PATCH] D118385: [NFC] Optimize FoldingSet usage where it matters

serge-sans-paille added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:214 mutable llvm::FoldingSet ComplexTypes; - mutable llvm::FoldingSet PointerTypes; + mutable llvm::FoldingSet PointerTypes{9}; mutable llvm::FoldingSet AdjustedTypes;

[PATCH] D118385: [NFC] Optimize FoldingSet usage where it matters

yurai007 created this revision. yurai007 added reviewers: nikic, xbolva00, aeubanks, ChuanqiXu, v.g.vassilev, serge-sans-paille, rsmith. Herald added subscribers: dexonsmith, pengfei, hiraditya. yurai007 requested review of this revision. Herald added projects: clang, LLVM. Herald added