[PATCH] D118690: [analyzer] Prevent misuses of -analyze-function

2022-02-16 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. I've decided to remove the offending RUN lines. It's less than ideal, but TBH I think it doesn't really matter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118690/new/ https://reviews.llvm.org/D118690 __

[PATCH] D118690: [analyzer] Prevent misuses of -analyze-function

2022-02-16 Thread Balázs Benics via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4642c640f4ef: [analyzer] Remove breaking RUN line in the test case (authored by steakhal). Changed prior to commit: https://reviews.llvm.org/D118690?vs=406845&id=409175#toc Repository: rG LLVM Github

[PATCH] D118690: [analyzer] Prevent misuses of -analyze-function

2022-02-08 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. In D118690#3305086 , @NoQ wrote: > Can you post a link to a specific buildbot failure so that we could look at > it together? Sure! I received these three mails: https://lab.llvm.org/buildbot#builders/67/builds/5824 https://la

[PATCH] D118690: [analyzer] Prevent misuses of -analyze-function

2022-02-08 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Can you post a link to a specific buildbot failure so that we could look at it together? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118690/new/ https://reviews.llvm.org/D118690 _

[PATCH] D118690: [analyzer] Prevent misuses of -analyze-function

2022-02-08 Thread Balázs Benics via Phabricator via cfe-commits
steakhal reopened this revision. steakhal added a comment. This revision is now accepted and ready to land. Ah, it seems like pinning the target triple was not enough. I'm stuck at this point. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118690/new

[PATCH] D118690: [analyzer] Prevent misuses of -analyze-function

2022-02-08 Thread Balázs Benics via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG841817b1ed26: [analyzer] Prevent misuses of -analyze-function (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D118690: [analyzer] Prevent misuses of -analyze-function

2022-02-07 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Thanks!! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118690/new/ https://reviews.llvm.org/D118690 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D118690: [analyzer] Prevent misuses of -analyze-function

2022-02-07 Thread Balázs Benics via Phabricator via cfe-commits
steakhal updated this revision to Diff 406463. steakhal added a comment. - pin target triple to (possibly) resolve the build bot failure - add obj-c test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118690/new/ https://reviews.llvm.org/D118690 Files: clang/lib/StaticAnalyzer/Fr

[PATCH] D118690: [analyzer] Prevent misuses of -analyze-function

2022-02-02 Thread Balázs Benics via Phabricator via cfe-commits
steakhal reopened this revision. steakhal added a comment. This revision is now accepted and ready to land. It broke some bots. I had to revert it in minutes it landed. Yet to be investigated how did it break something. Mind that I dont have any experience with objC. Repository: rG LLVM Githu

[PATCH] D118690: [analyzer] Prevent misuses of -analyze-function

2022-02-02 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:523 +"-analyze-function=foobar\n"; + } +} NoQ wrote: > NoQ wrote: > > 🥺 > You can use this for a test, should be in an .m file: > ```lang=objc > @in

[PATCH] D118690: [analyzer] Prevent misuses of -analyze-function

2022-02-02 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:523 +"-analyze-function=foobar\n"; + } +} NoQ wrote: > 🥺 You can use this for a test, should be in an .m file: ```lang=objc @interface MyClass -(int

[PATCH] D118690: [analyzer] Prevent misuses of -analyze-function

2022-02-02 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:523 +"-analyze-function=foobar\n"; + } +} 🥺 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118690/ne

[PATCH] D118690: [analyzer] Prevent misuses of -analyze-function

2022-02-02 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. Landed with the requested changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118690/new/ https://reviews.llvm.org/D118690 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D118690: [analyzer] Prevent misuses of -analyze-function

2022-02-02 Thread Balázs Benics via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. steakhal marked 3 inline comments as done. Closed by commit rG9d6a61597301: [analyzer] Prevent misuses of -analyze-function (authored by steakhal). Herald added a project: clang. Herald added a subscriber: cfe-commits. Chan