[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

Izaron marked 2 inline comments as done. Izaron added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/use-inline-const-variables-in-headers.hpp:1 +// RUN: %check_clang_tidy %s -std=c++17 modernize-use-inline-const-variables-in-headers %t +

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

Izaron updated this revision to Diff 498637. Izaron added a comment. Use the common `isInAnonymousNamespace` matcher. Split the test into two files. Thanks to @carlosgalvezp for advices! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118743/new/

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

Lounarok added a comment. > (//data member// is a variable inside a struct/class, but not a > "freestanding" one) Thanks for pointing that out. I misunderstood what //data member// is... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118743/new/

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseInlineConstVariablesInHeadersCheck.cpp:21-23 +AST_MATCHER(NamedDecl, isInAnonymousNamespace) { + return Node.isInAnonymousNamespace(); +} I recently added this matcher

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

Izaron added a comment. In D118743#3965423 , @Lounarok wrote: > I tried this patch and it's really helpful! You're welcome! > According to this , "A > `constexpr` specifier used in a function or

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

Lounarok added a comment. I tried this patch and it's really helpful! However I found that it warns when it comes to `constexpr static` variable. Snippet: `constexpr static int UNDEFINED_ERROR{0};` Warning msg: `warning: global constant 'UNDEFINED_ERROR' should be marked as 'inline'

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

Izaron added a comment. A friendly ping  Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118743/new/ https://reviews.llvm.org/D118743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

Izaron updated this revision to Diff 41. Izaron added a comment. Removed excessive newline. Thanks to @Eugene.Zelenko! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118743/new/ https://reviews.llvm.org/D118743 Files:

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/modernize/use-inline-const-variables-in-headers.rst:5 +=== + + Excessive newline. Repository: rG LLVM Github Monorepo

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

Izaron updated this revision to Diff 40. Izaron added a comment. Rebased onto main (after a long long time). Thanks to @LegalizeAdulthood for instructions! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118743/new/

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseInlineConstVariablesInHeadersCheck.cpp:64-68 + unless(hasType(isVolatileQualified())), // non-volatile + unless(isTemplateVariable()), //

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. This revision now requires changes to proceed. Clang-Tidy tests and docs have moved to module subdirectories. Please rebase this onto `main:HEAD` and: - fold your changes into the appropriate subdirs,

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

Izaron added a comment. In D118743#3290591 , @LegalizeAdulthood wrote: > You've probably had this check in development for some time, but > we just updated the documentation for contributing to clang-tidy > and it might help to go over it for your new

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

Izaron added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseInlineConstVariablesInHeadersCheck.cpp:64-68 + unless(hasType(isVolatileQualified())), // non-volatile + unless(isTemplateVariable()), // non-template

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

Izaron updated this revision to Diff 416347. Izaron marked 7 inline comments as done. Izaron added a comment. Herald added a project: All. Fix issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118743/new/ https://reviews.llvm.org/D118743

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseInlineConstVariablesInHeadersCheck.cpp:64-68 + unless(hasType(isVolatileQualified())), // non-volatile + unless(isTemplateVariable()), //

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

LegalizeAdulthood added a comment. You've probably had this check in development for some time, but we just updated the documentation for contributing to clang-tidy and it might help to go over it for your new check to see if there is anything that stands out.

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseInlineConstVariablesInHeadersCheck.h:33 +/// declarations in header files. True by default. +/// For the user-facing documentation see: +///

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

Izaron added a comment. For example, Google Code Style strongly advises C++17 `inline variables`. There are company guides how to use them: `https://abseil.io/tips/168`, `https://abseil.io/tips/140`. I believe other codestyles also use the feature. //P.S. If this review is eventually approved,

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

Izaron created this revision. Izaron added reviewers: alexfh, rsmith, LegalizeAdulthood. Herald added subscribers: carlosgalvezp, xazax.hun, mgorny. Izaron requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. C++17 `inline