This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8e10448cbbd9: [AArch64] Remove unused feature flags from
AArch64TargetInfo (authored by tyb0807).
Repository:
rG LLVM Github Monorepo
CHANGES
vhscampos accepted this revision.
vhscampos added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118757/new/
https://reviews.llvm.org/D118757
tyb0807 updated this revision to Diff 410418.
tyb0807 added a comment.
Revert latest change, as it is likely that people still rely on
`ARM_FEATURE_CRYPTO`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118757/new/
https://reviews.llvm.org/D118757
tyb0807 updated this revision to Diff 409796.
tyb0807 added a comment.
Remove reference to unused ACLE macro `__ARM_FEATURE_CRYPTO`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118757/new/
https://reviews.llvm.org/D118757
Files:
tyb0807 added a comment.
TL;DR, I think these `Has*` flags have different meaning in different places of
the code base.
IIUC, these `Has*` flags from `clang/lib/Basic/Targets/AArch64.cpp` are used to
correctly set various macros from the processed command line options, notable
ones from ACLE,
CarolineConcatto added a comment.
Just passing by, but I was wondering when I saw this patch.
Why you did not remove this also from lib/Driver/ToolChains/Arch/AArch64.cpp?
And the ones in llvm (AArch64.td, AArch64InstrInfo.td)?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
tyb0807 created this revision.
Herald added a subscriber: kristof.beyls.
tyb0807 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This removes two feature flags from `AArch64TargetInfo` class:
- `HasHBC`: this feature does not involve
