MaskRay requested changes to this revision.
MaskRay added inline comments.
This revision now requires changes to proceed.
Herald added a subscriber: StephenFan.
Comment at: clang/test/Driver/complex-range-flags.c:3
+
+// REQUIRES: clang-driver
+
delete
this is
zahiraam added inline comments.
Herald added a subscriber: MaskRay.
Herald added a project: All.
Comment at: clang/include/clang/Driver/Options.td:1853
+def fcx_fortran_rules : Flag<["-"], "fcx-fortran-rules">, Group;
+def fnocx_fortran_rules : Flag<["-"],
mdtoguchi added inline comments.
Comment at: clang/include/clang/Driver/Options.td:1853
+def fcx_fortran_rules : Flag<["-"], "fcx-fortran-rules">, Group;
+def fnocx_fortran_rules : Flag<["-"], "fnocx-fortran-rules">, Group;
+def cx_rangeEQ : Joined<["-"], "fcx-range=">, Group,
erichkeane added a subscriber: mdtoguchi.
erichkeane added a comment.
Same, other than the clang-format, I see nothing to be concerned about.
@mdtoguchi is my driver expert however.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119290/new/
aaron.ballman added reviewers: jansvoboda11, aaron.ballman, erichkeane.
aaron.ballman added a comment.
Adding some reviewers, but the changes here look reasonable to me. You should
fix the clang-format issues, though.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
jcranmer-intel created this revision.
Herald added a subscriber: dang.
jcranmer-intel requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
These are built on top of, and require, the complex intrinsics definitions to
work with. They are
