[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

qiucf marked 2 inline comments as done. qiucf added a comment. Thanks, fixed by rG2459ed67805c . `nmmintrin.h` just includes `smmintrin.h` so it's not critical. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

shchenz added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:170 + ppc_wrappers/immintrin.h + ppc_wrappers/tmmintrin.h + ppc_wrappers/x86intrin.h chapuni wrote: > It doesn't contain , forgot? @qiucf Looks like an error here? Repository: rG

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

chapuni added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:170 + ppc_wrappers/immintrin.h + ppc_wrappers/tmmintrin.h + ppc_wrappers/x86intrin.h It doesn't contain , forgot? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG406bde9a1513: [PowerPC] [Clang] Add SSE4 and BMI intrinsics implementation (authored by qiucf). Changed prior to commit:

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119407/new/ https://reviews.llvm.org/D119407

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

qiucf updated this revision to Diff 413336. qiucf added a comment. Herald added a project: All. Add P10 tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119407/new/ https://reviews.llvm.org/D119407 Files:

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

jsji added inline comments. Comment at: clang/lib/Headers/ppc_wrappers/xmmintrin.h:1332 +#ifdef _ARCH_PWR10 + return vec_extractm ((__vector unsigned int) __A); +#else Can we have some pwr10 tests to test all these P10 specific codegen? Repository: rG LLVM

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

qiucf updated this revision to Diff 409167. qiucf edited the summary of this revision. qiucf added a comment. Rebase the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119407/new/ https://reviews.llvm.org/D119407 Files:

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

qiucf planned changes to this revision. qiucf added a comment. This breaks existing smm/tmm tests, will update/clean-up them before this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119407/new/ https://reviews.llvm.org/D119407

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

qiucf updated this revision to Diff 407444. Herald added a subscriber: mgorny. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119407/new/ https://reviews.llvm.org/D119407 Files: clang/lib/Headers/CMakeLists.txt

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

qiucf created this revision. qiucf added reviewers: jsji, nemanjai, PowerPC, shchenz. Herald added subscribers: kbarton, krytarowski. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo