klimek added a reviewer: bkramer.
klimek added a comment.
+Benjamin to share another yak :D
http://reviews.llvm.org/D11944
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bkramer added a comment.
Can you try setting up the virtual files with the vfs::InMemoryFileSystem
stuff? There are some examples how to set up with OverlayFileSystem in tree.
InMemoryFileSystem was written with windows path separators in mind, I just
never tried to run it on windows :)
On Thu, Aug 13, 2015 at 10:50 AM, Richard Smith via cfe-commits
cfe-commits@lists.llvm.org wrote:
rsmith added a comment.
I would think most Windows users would be surprised if we showed them
paths with /s instead of \s, but I'm fine with us using / internally if it
doesn't leak out to the
yaron.keren added inline comments.
Comment at: lib/Basic/FileManager.cpp:221-222
@@ -220,1 +220,4 @@
+ SmallString1024 NativeFilename;
+ llvm::sys::path::native(Filename, NativeFilename);
+
rsmith wrote:
I have two concerns with this:
1) It's needlessly
chapuni added a comment.
I wish, in clang/llvm, internal path separator would be slash.
It'd be better to use backslash where it'd be really required, for example
interface to cmd.exe or MS toolchain.
For me, native-ization is nightmare.
http://reviews.llvm.org/D11944
klimek added a comment.
In http://reviews.llvm.org/D11944#223597, @chapuni wrote:
I wish, in clang/llvm, internal path separator would be slash.
It'd be better to use backslash where it'd be really required, for example
interface to cmd.exe or MS toolchain.
For me, native-ization is
rsmith added a comment.
In principle, normalizing slashes on Windows makes sense here. But we shouldn't
use `llvm::sys::path::native`, because it's just too broken.
Comment at: lib/Basic/FileManager.cpp:221-222
@@ -220,1 +220,4 @@
+ SmallString1024 NativeFilename;
+
yaron.keren added a subscriber: yaron.keren.
yaron.keren added a comment.
There is also the case insensitivity issue, see
https://llvm.org/bugs/show_bug.cgi?id=17993
http://reviews.llvm.org/D11944
___
cfe-commits mailing list
klimek added a comment.
The case sensitivity stuff is related, but a much larger problem - while the
native paths are system dependent, the case sensitivity is file system
dependent - I can have case insensitive file systems on any OS.
http://reviews.llvm.org/D11944
