Re: [PATCH] D11946: Create clang-tidy module modernize. Add pass-by-value check.

2015-08-14 Thread Alexander Kornienko via cfe-commits
alexfh closed this revision. alexfh added a comment. Committed revision 245045. http://reviews.llvm.org/D11946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11946: Create clang-tidy module modernize. Add pass-by-value check.

2015-08-14 Thread Alexander Kornienko via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Now the tests pass. Thanks for fixing the IncludeInserter bug! http://reviews.llvm.org/D11946 ___ cfe-commits mailing list

Re: [PATCH] D11946: Create clang-tidy module modernize. Add pass-by-value check.

2015-08-13 Thread Angel Garcia via cfe-commits
angelgarcia updated this revision to Diff 32036. angelgarcia marked 4 inline comments as done. angelgarcia added a comment. Set IncludeStyle as an option. Fix comments. http://reviews.llvm.org/D11946 Files: clang-tidy/CMakeLists.txt clang-tidy/Makefile clang-tidy/modernize/CMakeLists.txt

Re: [PATCH] D11946: Create clang-tidy module modernize. Add pass-by-value check.

2015-08-13 Thread Angel Garcia via cfe-commits
angelgarcia updated this revision to Diff 32059. angelgarcia added a comment. Remove StringSwitch. http://reviews.llvm.org/D11946 Files: clang-tidy/CMakeLists.txt clang-tidy/Makefile clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/Makefile

Re: [PATCH] D11946: Create clang-tidy module modernize. Add pass-by-value check.

2015-08-12 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. Something weird happened with the file names in this CL after the latest update, e.g. there are both `clang-tidy/CMakeLists.txt` and `CMakeLists.txt`. How exactly did you create the Differential revision and update it? Comment at: