[PATCH] D119562: Provide fine control of color in run-clang-tidy

kesyog marked an inline comment as done. kesyog added a comment. Thanks for the suggestions. I removed `-no-use-color` and modified `-use-color` to follow the behavior of LLVM's CLI parser. I also fixed the (very unintentional) file mode change. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D119562: Provide fine control of color in run-clang-tidy

kesyog updated this revision to Diff 410132. kesyog added a comment. Use argument style more consistent with clang-tidy & LLVM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119562/new/ https://reviews.llvm.org/D119562 Files: clang-tools-extra/cl

[PATCH] D119562: Provide fine control of color in run-clang-tidy

njames93 added a comment. Why have you removed execute perms form the scripts, can you add them back please `$ chmod +x run-clang-tidy.py'` Unless you are using windows in which case you will have to manually edit the diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D119562: Provide fine control of color in run-clang-tidy

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py:240-249 + color_group = parser.add_mutually_exclusive_group() + color_group.add_argument('-use-color', action='store_true', dest='use_color', + help='Use co

[PATCH] D119562: Provide fine control of color in run-clang-tidy

kesyog marked an inline comment as done. kesyog added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119562/new/ https://reviews.llvm.org/D119562 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D119562: Provide fine control of color in run-clang-tidy

kesyog marked an inline comment as done. kesyog added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py:96 +start.append('--use-color') + elif use_color is not None: +start.append('--use-color=false') Eugene.Zelenko wrote:

[PATCH] D119562: Provide fine control of color in run-clang-tidy

kesyog updated this revision to Diff 407950. kesyog added a comment. Refactor tri-state logic for readability Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119562/new/ https://reviews.llvm.org/D119562 Files: clang-tools-extra/clang-tidy/tool/run

[PATCH] D119562: Provide fine control of color in run-clang-tidy

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py:96 +start.append('--use-color') + elif use_color is not None: +start.append('--use-color=false') kesyog wrote: > Eugene.Zelenko wrote: > > Shouldn't it

[PATCH] D119562: Provide fine control of color in run-clang-tidy

kesyog added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py:96 +start.append('--use-color') + elif use_color is not None: +start.append('--use-color=false') Eugene.Zelenko wrote: > Shouldn't it be just `else:`? There are

[PATCH] D119562: Provide fine control of color in run-clang-tidy

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py:96 +start.append('--use-color') + elif use_color is not None: +start.append('--use-color=false') Shouldn't it be just `else:`? Repository: rG LLVM G

[PATCH] D119562: Provide fine control of color in run-clang-tidy

kesyog created this revision. Herald added a subscriber: carlosgalvezp. kesyog requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. D90110 modified the behavior of `run-clang-tidy` to always pass th