[PATCH] D119949: [Clang-tidy] Check the existence of ElaboratedType's qualifiers

This revision was automatically updated to reflect the committed changes. Closed by commit rGac616fbb05b8: [Clang-tidy] Check the existence of ElaboratedTypes qualifiers (authored by junaire). Changed prior to commit: https://reviews.llvm.org/D119949?vs=409511=412111#toc Repository: rG LLVM

[PATCH] D119949: [Clang-tidy] Check the existence of ElaboratedType's qualifiers

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. Fix one nit and ship Comment at: clang-tools-extra/clang-tidy/readability/StaticAccessedThroughInstanceCheck.cpp:74 +

[PATCH] D119949: [Clang-tidy] Check the existence of ElaboratedType's qualifiers

junaire added a comment. In D119949#3338818 , @junaire wrote: > Gentle ping~ Gentle ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119949/new/ https://reviews.llvm.org/D119949

[PATCH] D119949: [Clang-tidy] Check the existence of ElaboratedType's qualifiers

junaire added a comment. Gentle ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119949/new/ https://reviews.llvm.org/D119949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D119949: [Clang-tidy] Check the existence of ElaboratedType's qualifiers

junaire updated this revision to Diff 409511. junaire added a comment. Simplify code a little bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119949/new/ https://reviews.llvm.org/D119949 Files:

[PATCH] D119949: [Clang-tidy] Check the existence of ElaboratedType's qualifiers

junaire updated this revision to Diff 409510. junaire added a comment. - Only suppress canonical types when it's a TypedefNameType. - Add more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119949/new/ https://reviews.llvm.org/D119949

[PATCH] D119949: [Clang-tidy] Check the existence of ElaboratedType's qualifiers

junaire added a comment. In D119949#3328254 , @cloudhan wrote: > As the original bug reporter, I don't think this is a proper fix for it. > There seems to be some kind of bug deep in the frontend. This just hide it > anyway. Yeah, maybe there's a

[PATCH] D119949: [Clang-tidy] Check the existence of ElaboratedType's qualifiers

cloudhan added a comment. As the original bug reporter, I don't think this a proper fix for it. There seems to be some kind of bug deep in the frontend. This just hide it anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119949/new/

[PATCH] D119949: [Clang-tidy] Check the existence of ElaboratedType's qualifiers

junaire created this revision. junaire added reviewers: aaron.ballman, alexfh. Herald added subscribers: carlosgalvezp, xazax.hun. junaire requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The ElaboratedType can have no