[PATCH] D119979: [OpenMP] Diagnose bad 'omp declare variant' that references itself

2022-02-17 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. In D119979#3330343 , @mikerice wrote: > What's the use case? I wasn't aware of any. We saw it from someone who did > it accidently and caused the compiler to crash in codegen. If you have N overloads/variants and you want to

[PATCH] D119979: [OpenMP] Diagnose bad 'omp declare variant' that references itself

2022-02-17 Thread Mike Rice via Phabricator via cfe-commits
mikerice added a comment. What's the use case? I wasn't aware of any. We saw it from someone who did it accidently and caused the compiler to crash in codegen. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119979/new/ https://reviews.llvm.org/D11

[PATCH] D119979: [OpenMP] Diagnose bad 'omp declare variant' that references itself

2022-02-17 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert reopened this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Why is this supposed to be a user error? I don't remember the standard disallowing this and I can see use cases for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D119979: [OpenMP] Diagnose bad 'omp declare variant' that references itself

2022-02-17 Thread Mike Rice via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG383f3a467c92: [OpenMP] Diagnose bad 'omp declare variant' that references itself. (authored by mikerice). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Githu