[PATCH] D120106: [OpenMP] Add flag for disabling threat state in runtime

ye-luo added a comment. Change title threat state to thread state Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120106/new/ https://reviews.llvm.org/D120106 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D120106: [OpenMP] Add flag for disabling threat state in runtime

jhuber6 updated this revision to Diff 409850. jhuber6 added a comment. Changing assert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120106/new/ https://reviews.llvm.org/D120106 Files: clang/include/clang/Basic/LangOptions.def clang/include/cl

[PATCH] D120106: [OpenMP] Add flag for disabling threat state in runtime

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Last nit, otherwise LG Comment at: openmp/libomptarget/DeviceRTL/src/State.cpp:385 + if (!config::mayUseThreadStates()) +ASSERT(false && "Thread state modified whi

[PATCH] D120106: [OpenMP] Add flag for disabling threat state in runtime

jhuber6 updated this revision to Diff 409847. jhuber6 added a comment. Change name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120106/new/ https://reviews.llvm.org/D120106 Files: clang/include/clang/Basic/LangOptions.def clang/include/clang/

[PATCH] D120106: [OpenMP] Add flag for disabling threat state in runtime

jhuber6 updated this revision to Diff 409845. jhuber6 added a comment. Making suggested changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120106/new/ https://reviews.llvm.org/D120106 Files: clang/include/clang/Basic/LangOptions.def clang/

[PATCH] D120106: [OpenMP] Add flag for disabling threat state in runtime

jdoerfert added a comment. I'd go with `config::mayRequireThreadSpecificState` or sth. Also some documentation there. you should be able to use assertions, like `ASSERT(false && "")`. Which gives us messages in assert mode if violated. Clang documentation should be something like `no thread

[PATCH] D120106: [OpenMP] Add flag for disabling threat state in runtime

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992. Herald added subscribers: dexonsmith, dang, guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, sstefan1. Herald added projects: clang, OpenMP. The run