[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

mgorny added a comment. Thanks. The usual way of doing is to move the necessary bits to `llvm-config.h`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120185/new/ https://reviews.llvm.org/D120185 ___

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

njames93 closed this revision. njames93 added a comment. In D120185#3668029 , @mgorny wrote: > This change broke standalone build of clang. Please fix. I've pushed rG251b5b864183e868ffc86522e320f91ab3c5a771

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

mgorny reopened this revision. mgorny added a comment. This revision is now accepted and ready to land. This change broke standalone build of clang. Please fix. Comment at: clang/unittests/ASTMatchers/ASTMatchersInternalTest.cpp:15 #include "llvm/ADT/Triple.h" +#include

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

njames93 added a comment. I've landed it and your build bot is happy, there was another failing buildbot so I'll keep an eye on it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120185/new/ https://reviews.llvm.org/D120185

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

aaron.ballman added a comment. In D120185#3408258 , @thakis wrote: > That bot sets ENABLE_BACKTRACES=1. > > It seems to work for clang-cl (foo.cc contains `#pragma clang __debug > parser_crash`): > > >out\gn\bin\clang-cl /c foo.cc > PLEASE submit a

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

thakis added a comment. That bot sets ENABLE_BACKTRACES=1. It seems to work for clang-cl (foo.cc contains `#pragma clang __debug parser_crash`): >out\gn\bin\clang-cl /c foo.cc PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace,

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

aaron.ballman added a comment. In D120185#3406765 , @njames93 wrote: > In D120185#3405091 , @aaron.ballman > wrote: > >> @thakis -- is it possible your build bot is configured to disable generation >> of crash

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

njames93 added a comment. In D120185#3405091 , @aaron.ballman wrote: > @thakis -- is it possible your build bot is configured to disable generation > of crash dumps? So with a lot of trial and error, it seems that on certain windows configurations,

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

aaron.ballman added a comment. In D120185#3403676 , @njames93 wrote: > In D120185#3403270 , @aaron.ballman > wrote: > >> I'd like to understand what's happening better rather than land with a >> disabled test.

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

njames93 added a comment. In D120185#3403270 , @aaron.ballman wrote: > I'd like to understand what's happening better rather than land with a > disabled test. Not getting the crash dump in some circumstances could either > be specific to the machine

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

aaron.ballman added a comment. In D120185#3403230 , @njames93 wrote: > In D120185#3397508 , @thakis wrote: > >> Looks like this breaks tests on Windows: >> http://45.33.8.238/win/54785/step_7.txt >> >> Please

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

njames93 added a comment. In D120185#3397508 , @thakis wrote: > Looks like this breaks tests on Windows: > http://45.33.8.238/win/54785/step_7.txt > > Please take a look, and revert for now if takes a while to fix. I can't seem to reproduce the test

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

njames93 added a comment. In D120185#3397508 , @thakis wrote: > Looks like this breaks tests on Windows: > http://45.33.8.238/win/54785/step_7.txt > > Please take a look, and revert for now if takes a while to fix. Seems to be that on windows we aren't

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

thakis added a comment. Looks like this breaks tests on Windows: http://45.33.8.238/win/54785/step_7.txt Please take a look, and revert for now if takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120185/new/

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd89f9e963e49: [ASTMatchers] Output currently processing match and nodes on crash (authored by njames93). Repository: rG LLVM Github Monorepo

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120185/new/ https://reviews.llvm.org/D120185

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

njames93 updated this revision to Diff 417041. njames93 added a comment. Remove from Decls that aren't NamedDecls Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120185/new/ https://reviews.llvm.org/D120185 Files:

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

njames93 updated this revision to Diff 416994. njames93 marked 5 inline comments as done. njames93 added a comment. Rework testing infrastructure. Add more test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120185/new/

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

aaron.ballman added a comment. Essentially looks good to me now, thanks! Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:789 + else +OS << " "; + D->getSourceRange().print(OS, njames93 wrote: > aaron.ballman wrote: > > Should

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

njames93 added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:796 +MV.ActiveASTContext->getSourceManager()); +} else if (const auto *T = Item.second.get()) { + OS << T->getTypeClassName() << "Type : ";

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

aaron.ballman added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:796 +MV.ActiveASTContext->getSourceManager()); +} else if (const auto *T = Item.second.get()) { + OS << T->getTypeClassName() << "Type :

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

njames93 added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:789 + else +OS << " "; + D->getSourceRange().print(OS, aaron.ballman wrote: > Should this be `" : "` instead? Good catch Comment

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

aaron.ballman added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:789 + else +OS << " "; + D->getSourceRange().print(OS, Should this be `" : "` instead? Comment at:

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

njames93 updated this revision to Diff 412793. njames93 added a comment. Update test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120185/new/ https://reviews.llvm.org/D120185 Files: clang-tools-extra/docs/ReleaseNotes.rst

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

njames93 updated this revision to Diff 412772. njames93 added a comment. Herald added a project: All. Moved tests into ASTMatchersInternal, makes sense in here and removes the dirty clang-tidy plugin hack. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

njames93 added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:1536 void MatchFinder::match(const clang::DynTypedNode , ASTContext ) { internal::MatchASTVisitor Visitor(, Options); Visitor.set_active_ast_context(); Is there a

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

njames93 updated this revision to Diff 410139. njames93 added a comment. Moved TraceReporter into the MatchASTVisitor class Added some missing new lines Fixed patch not being based off a commit in trunk Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

njames93 added a comment. I've reused the test cases from the old clang-tidy implementation of this, however this should eventually be moved into ASTMatchers tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120185/new/

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

njames93 created this revision. njames93 added reviewers: klimek, aaron.ballman, LegalizeAdulthood. Herald added a subscriber: mgorny. njames93 requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Create a