[PATCH] D120201: [Clang] Extend -gen-reproducer flag

2022-06-01 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added subscribers: browneee, vitalybuka. vitalybuka added a comment. This patch breaks msan bots: https://lab.llvm.org/buildbot/#/builders/5/builds/24307 and https://lab.llvm.org/buildbot/#/builders/74 https://lab.llvm.org/buildbot/#/builders/5/builds/24335 is (last green build

[PATCH] D120201: [Clang] Extend -gen-reproducer flag

2022-05-31 Thread Douglas Yung via Phabricator via cfe-commits
dyung added a comment. In D120201#3547835 , @abrachet wrote: > In D120201#3547834 , @dyung wrote: > >> The test you added seems to be failing on the PS4 Windows bot. A quick >> glance seems to suggest that you

[PATCH] D120201: [Clang] Extend -gen-reproducer flag

2022-05-31 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added a comment. In D120201#3547834 , @dyung wrote: > The test you added seems to be failing on the PS4 Windows bot. A quick glance > seems to suggest that you aren't properly escaping the path separators > somewhere. Can you take a look and

[PATCH] D120201: [Clang] Extend -gen-reproducer flag

2022-05-31 Thread Douglas Yung via Phabricator via cfe-commits
dyung added a comment. The test you added seems to be failing on the PS4 Windows bot. A quick glance seems to suggest that you aren't properly escaping the path separators somewhere. Can you take a look and revert if you need time to investigate?

[PATCH] D120201: [Clang] Extend -gen-reproducer flag

2022-05-31 Thread Alex Brachet via Phabricator via cfe-commits
abrachet updated this revision to Diff 433122. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120201/new/ https://reviews.llvm.org/D120201 Files: clang/include/clang/Driver/Driver.h clang/include/clang/Driver/Options.td clang/lib/Driver/Driver.cpp

[PATCH] D120201: [Clang] Extend -gen-reproducer flag

2022-05-31 Thread Alex Brachet via Phabricator via cfe-commits
abrachet updated this revision to Diff 433120. abrachet marked an inline comment as done. abrachet added a comment. Fix tests on macOS and compile test with `-fsyntax-only` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120201/new/ https://reviews.llvm.org/D120201 Files:

[PATCH] D120201: [Clang] Extend -gen-reproducer flag

2022-05-27 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Looks like this breaks tests on (at least) Mac and window, see eg http://45.33.8.238/macm1/36198/step_7.txt (passes on my Linux bit though). Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D120201: [Clang] Extend -gen-reproducer flag

2022-05-27 Thread Alex Brachet via Phabricator via cfe-commits
abrachet marked an inline comment as done. abrachet added inline comments. Comment at: clang/test/Driver/emit-reproducer.c:1 +// RUN: rm -rf %t; mkdir %t + hans wrote: > I'm not sure if lit handles that semicolon, or if it hands this over to the > shell, in

[PATCH] D120201: [Clang] Extend -gen-reproducer flag

2022-05-27 Thread Alex Brachet via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG684c08010876: [Clang] Extend -gen-reproducer flag (authored by abrachet). Herald added a project: clang. Herald added a subscriber: cfe-commits.