[PATCH] D120246: [flang][driver] Add support for `--target`/`--triple`

awarzynski added a comment. Thank you all for taking a look! I've just realised this: "This revision was not accepted when it landed; it landed in state Needs Review." Just to clarify, I merged this as two reviewers accepted this in comments (with "LGTM"). Also, I believe that I addressed all

[PATCH] D120246: [flang][driver] Add support for `--target`/`--triple`

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e9439e4891c: [flang][driver] Add support for

[PATCH] D120246: [flang][driver] Add support for `--target`/`--triple`

MatsPetersson added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120246/new/ https://reviews.llvm.org/D120246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D120246: [flang][driver] Add support for `--target`/`--triple`

awarzynski updated this revision to Diff 410836. awarzynski added a comment. Rebase on top of `main` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120246/new/ https://reviews.llvm.org/D120246 Files: clang/include/clang/Driver/Options.td

[PATCH] D120246: [flang][driver] Add support for `--target`/`--triple`

awarzynski added inline comments. Comment at: clang/include/clang/Driver/Options.td:4815 -} +} // let Flags = [CC1Option, CC1AsOption, NoDriverOption] + schweitz wrote: > Is this comment something left over from edits? This is intentional (there's already a [[

[PATCH] D120246: [flang][driver] Add support for `--target`/`--triple`

schweitz added inline comments. Comment at: clang/include/clang/Driver/Options.td:4815 -} +} // let Flags = [CC1Option, CC1AsOption, NoDriverOption] + Is this comment something left over from edits? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D120246: [flang][driver] Add support for `--target`/`--triple`

schweitz added a comment. > In D120246#3339289 , @tschuett > wrote: > >> https://reviews.llvm.org/D117809 >> >> There was a discussion that `-emit-llvm` is considered a mistake. > > Which comment are you referring to specifically? Also, `-emit-llvm` is

[PATCH] D120246: [flang][driver] Add support for `--target`/`--triple`

awarzynski added a comment. Thank you both for taking a look! In D120246#3339284 , @rovka wrote: > Nit: Should we also have a test for print-effective-triple? Added. > I'm not sure that -emit-llvm is necessarily something we'd want flang users > to

[PATCH] D120246: [flang][driver] Add support for `--target`/`--triple`

awarzynski updated this revision to Diff 410826. awarzynski added a comment. Add a test for `--print-effective-triple` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120246/new/ https://reviews.llvm.org/D120246 Files:

[PATCH] D120246: [flang][driver] Add support for `--target`/`--triple`

tschuett added subscribers: MaskRay, tschuett. tschuett added a comment. https://reviews.llvm.org/D117809 There was a discussion that `-emit-llvm` is considered a mistake. @MaskRay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120246/new/

[PATCH] D120246: [flang][driver] Add support for `--target`/`--triple`

rovka added a comment. Nit: Should we also have a test for print-effective-triple? Otherwise LGTM, although I'm not sure that -emit-llvm is necessarily something we'd want flang users to be exposed to. Comment at: flang/include/flang/Frontend/TargetOptions.h:20 +/// Options

[PATCH] D120246: [flang][driver] Add support for `--target`/`--triple`

awarzynski updated this revision to Diff 410469. awarzynski added a comment. Add TargetOptions.h (that I forgot to add earlier) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120246/new/ https://reviews.llvm.org/D120246 Files:

[PATCH] D120246: [flang][driver] Add support for `--target`/`--triple`

awarzynski created this revision. awarzynski added reviewers: rovka, clementval, schweitz, Leporacanthicus. Herald added subscribers: dang, usaxena95, kadircet. Herald added a reviewer: sscalpone. Herald added a project: Flang. awarzynski requested review of this revision. Herald added