[PATCH] D120331: [clang-tidy][run-clang-tidy.py] Add --config-file= option

aaron.ballman closed this revision. aaron.ballman added a comment. In D120331#3384889 , @SAtacker wrote: > Gentle reminder to commit on my behalf > @JonasToth > @alexfh > @aaron.ballman > @njames93 > @LegalizeAdulthood > > Thank yo

[PATCH] D120331: [clang-tidy][run-clang-tidy.py] Add --config-file= option

SAtacker marked an inline comment as done. SAtacker added a comment. Gentle reminder @JonasToth @alexfh @aaron.ballman @njames93 @LegalizeAdulthood Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120331/new/ https://reviews.llvm.org/D

[PATCH] D120331: [clang-tidy][run-clang-tidy.py] Add --config-file= option

SAtacker marked an inline comment as done. SAtacker added a comment. Gentle ping @alexfh @JonasToth Thank you. Comment at: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py:228 'default') - parser.add_argument('-config', default=None, + group = parse

[PATCH] D120331: [clang-tidy][run-clang-tidy.py] Add --config-file= option

SAtacker updated this revision to Diff 412397. SAtacker added a comment. [clang-tidy][run-clang-tidy.py] Rename `group` to `config_group` Signed-off-by: Shreyas Atre Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120331/new/ https://reviews.llvm.o

[PATCH] D120331: [clang-tidy][run-clang-tidy.py] Add --config-file= option

SAtacker added a comment. In D120331#3354021 , @JonasToth wrote: > LGTM, but please adjust the naming nit to a better name. Thanks for the review again. Will rename the `group` to `config_group` as you suggested and I feel that too. > do you have commi

[PATCH] D120331: [clang-tidy][run-clang-tidy.py] Add --config-file= option

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. Herald added a project: All. LGTM, but please adjust the naming nit to a better name. do you have commit rights? Otherwise someone (e.g. me) could commit on your behalf, of course with a

[PATCH] D120331: [clang-tidy][run-clang-tidy.py] Add --config-file= option

SAtacker added a comment. @JonasToth Could you please review it? Comment at: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py:236 'each source file in its parent directories.') + parser.add_argument('-config-file', default=None, +

[PATCH] D120331: [clang-tidy][run-clang-tidy.py] Add --config-file= option

SAtacker updated this revision to Diff 410736. SAtacker marked an inline comment as done. SAtacker added a comment. Squash commits D120385 , D120387 into D120331 Repository: rG LLVM Github

[PATCH] D120331: [clang-tidy][run-clang-tidy.py] Add --config-file= option

JonasToth added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py:236 'each source file in its parent directories.') + parser.add_argument('-config-file', default=None, + help='Specify the path of .clang-

[PATCH] D120331: [clang-tidy][run-clang-tidy.py] Add --config-file= option

SAtacker created this revision. SAtacker added a reviewer: JonasToth. Herald added subscribers: carlosgalvezp, xazax.hun. SAtacker requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. - Link to the GitHub Issue: https://github.com/ll