This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9edeceaece60: [libTooling] Generalize string explanation as
templated metadata (authored by li.zhe.hua, committed by ymandel).
Repository:
rG LLVM
li.zhe.hua updated this revision to Diff 417063.
li.zhe.hua added a comment.
Fix issue with "explicit specialization in non-namespace scope"
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120360/new/
https://reviews.llvm.org/D120360
Files:
clang-
This revision was automatically updated to reflect the committed changes.
Closed by commit rG18440547d352: [libTooling] Generalize string explanation as
templated metadata (authored by li.zhe.hua, committed by ymandel).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://re
li.zhe.hua added inline comments.
Comment at: clang/include/clang/Tooling/Transformer/Transformer.h:103-108
+ template >>::value,
+int> = 0>
li.zhe.hua wrote:
> asoffer wrote:
> > Given that we're simply passing this off to the NoMetadataImpl whi
li.zhe.hua updated this revision to Diff 412823.
li.zhe.hua marked 2 inline comments as done.
li.zhe.hua added a comment.
Update comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120360/new/
https://reviews.llvm.org/D120360
Files:
clang-too
li.zhe.hua updated this revision to Diff 412799.
li.zhe.hua added a comment.
Try removing all the SFINAE
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120360/new/
https://reviews.llvm.org/D120360
Files:
clang-tools-extra/clang-tidy/abseil/Cleanu
li.zhe.hua added inline comments.
Comment at: clang/include/clang/Tooling/Transformer/Transformer.h:103-108
+ template >>::value,
+int> = 0>
asoffer wrote:
> Given that we're simply passing this off to the NoMetadataImpl which accepts
> a std::f
ymandel accepted this revision.
ymandel added inline comments.
Comment at: clang/include/clang/Tooling/Transformer/Transformer.h:116
+ explicit Transformer(transformer::RewriteRuleWith Rule,
+ ConsumerFn Consumer);
asoffer wrote:
> li.zhe
asoffer added inline comments.
Comment at: clang/include/clang/Tooling/Transformer/Transformer.h:103-108
+ template >>::value,
+int> = 0>
Given that we're simply passing this off to the NoMetadataImpl which accepts a
std::function, I don't see a
