[PATCH] D120395: [X86] Prohibit arithmetic operations on type `__bfloat16`

pengfei abandoned this revision. pengfei added a comment. This is not needed anymore, thanks @RKSimon Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120395/new/ https://reviews.llvm.org/D120395 ___

[PATCH] D120395: [X86] Prohibit arithmetic operations on type `__bfloat16`

RKSimon added a comment. Herald added a subscriber: StephenFan. @pengfei Do we still need this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120395/new/ https://reviews.llvm.org/D120395 ___ cfe-commits

[PATCH] D120395: [X86] Prohibit arithmetic operations on type `__bfloat16`

skan added a comment. In D120395#3365622 , @craig.topper wrote: >> So at this point we have these options: >> >> 1. Make the `__m[128|256|512]bh` types aliases of `__m[128|256|512]i` >> 2. Deprecate the `__m[128|256|512]bh` types and replace them with

[PATCH] D120395: [X86] Prohibit arithmetic operations on type `__bfloat16`

craig.topper added a comment. > So at this point we have these options: > > 1. Make the `__m[128|256|512]bh` types aliases of `__m[128|256|512]i` > 2. Deprecate the `__m[128|256|512]bh` types and replace them with > `__m[128|256|512]i` > 3. Add load/store/insert/extract intrinsics for the

[PATCH] D120395: [X86] Prohibit arithmetic operations on type `__bfloat16`

andrew.w.kaylor added a comment. In D120395#3359255 , @pengfei wrote: > I don't agree. Unlike `__fp16`, `__bf16` is simple an ARM specific type. Why is __bf16 an ARM-specific type? It's a type that describes a floating point value with a specific

[PATCH] D120395: [X86] Prohibit arithmetic operations on type `__bfloat16`

andrew.w.kaylor added a comment. In D120395#3358533 , @craig.topper wrote: > __m256bh should not have been a new type. It should have been an alias of > __m256i. We don't have load/store intrinsics for __m256bh so if you can even > get the __m256bh

[PATCH] D120395: [X86] Prohibit arithmetic operations on type `__bfloat16`

pengfei added a comment. > if we define the `__bfloat16` type as the built-in `__bf16` type, then the > front end can apply whatever rules it has for that type, including adding > whatever ABI handling is needed for BF16 values. I don't agree. Unlike `__fp16`, `__bf16` is simple an ARM

[PATCH] D120395: [X86] Prohibit arithmetic operations on type `__bfloat16`

craig.topper added a comment. In D120395#3358533 , @craig.topper wrote: > In D120395#3358453 , > @andrew.w.kaylor wrote: > >> In D120395#3356355 , @pengfei >> wrote:

[PATCH] D120395: [X86] Prohibit arithmetic operations on type `__bfloat16`

craig.topper added a comment. In D120395#3358453 , @andrew.w.kaylor wrote: > In D120395#3356355 , @pengfei wrote: > >> Good question! This is actually the scope of ABI. Unfortunately, we don't >> have the BF16

[PATCH] D120395: [X86] Prohibit arithmetic operations on type `__bfloat16`

andrew.w.kaylor added a comment. In D120395#3356355 , @pengfei wrote: > Good question! This is actually the scope of ABI. Unfortunately, we don't > have the BF16 ABI at the present. We can't assume what are the physical > registers the arguments been

[PATCH] D120395: [X86] Prohibit arithmetic operations on type `__bfloat16`

pengfei added a comment. Thanks @andrew.w.kaylor ! You are totally correct about the intention and current implementations. > Concretely, what are the semantics that we want for the BF16 types and > intrinsics? Unlike the other floating-point types, there's no standard to > guide this, so

[PATCH] D120395: [X86] Prohibit arithmetic operations on type `__bfloat16`

andrew.w.kaylor added a comment. Herald added a project: All. In D120395#3346591 , @scanon wrote: > There's a lot of churn around proposed "solutions" on this and related PR, > but not a very clear analysis of what the problem we're trying to solve is.

[PATCH] D120395: [X86] Prohibit arithmetic operations on type `__bfloat16`

scanon added a comment. There's a lot of churn around proposed "solutions" on this and related PR, but not a very clear analysis of what the problem we're trying to solve is. Concretely, what are the semantics that we want for the BF16 types and intrinsics? Unlike the other floating-point

[PATCH] D120395: [X86] Prohibit arithmetic operations on type `__bfloat16`

andrew.w.kaylor added inline comments. Comment at: clang/lib/Headers/avx512bf16intrin.h:37 ///and fraction field is extended to 23 bits. -static __inline__ float __DEFAULT_FN_ATTRS _mm_cvtsbh_ss(__bfloat16 __A) { +static __inline__ float __DEFAULT_FN_ATTRS

[PATCH] D120395: [X86] Prohibit arithmetic operations on type `__bfloat16`

andrew.w.kaylor added a comment. In D120395#3344890 , @pengfei wrote: > Disscussed with GCC folks. We think it's better to use the same way as > D120411 that replacing it with short int. Which GCC folks did you