This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf2b24905bfed: [Sema] Mark the referenced destructor during
transformation of a… (authored by akyrtzi).
Herald added a project: All.
Repository:
akyrtzi updated this revision to Diff 411219.
akyrtzi added a comment.
Add a target triple to the test, so it can pass on windows.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120426/new/
https://reviews.llvm.org/D120426
Files:
akyrtzi updated this revision to Diff 411186.
akyrtzi added a comment.
Move the `const_cast` to the call site.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120426/new/
https://reviews.llvm.org/D120426
Files:
clang/lib/Sema/TreeTransform.h
akyrtzi updated this revision to Diff 411185.
akyrtzi added a comment.
Make sure to check the destructor decl pointer for nil before passing to
`Sema::MarkFunctionReferenced()`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120426/new/
jansvoboda11 accepted this revision.
jansvoboda11 added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120426/new/
https://reviews.llvm.org/D120426
akyrtzi created this revision.
akyrtzi requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Otherwise we will fail to generate the definition of a defaulted destructor,
if the only reference was in a templated temporary.
rdar://89366678
