Re: [PATCH] D12052: [X86][SSE] Add _mm_undefined_* intrinsics

2015-08-19 Thread Simon Pilgrim via cfe-commits
RKSimon updated this revision to Diff 32514. RKSimon added a comment. Added ia32 builtin undef intrinsics (I didn't bother with the mmx as I can't find any evidence of an undefined intrinsic for it). Added the avx512 intrinsics referenced in the intel intrinsics guide. Technically there's

RE: [PATCH] D12052: [X86][SSE] Add _mm_undefined_* intrinsics

2015-08-18 Thread Kuperstein, Michael M via cfe-commits
...@gmail.com; Kuperstein, Michael M Cc: david.majne...@gmail.com; Badouh, Asaf; cfe-commits@lists.llvm.org; Richard Smith Subject: Re: [PATCH] D12052: [X86][SSE] Add _mm_undefined_* intrinsics On Sun, Aug 16, 2015 at 3:05 AM Simon Pilgrim llvm-...@redking.me.ukmailto:llvm-...@redking.me.uk wrote: RKSimon

Re: [PATCH] D12052: [X86][SSE] Add _mm_undefined_* intrinsics

2015-08-17 Thread Eric Christopher via cfe-commits
On Sun, Aug 16, 2015 at 3:05 AM Simon Pilgrim llvm-...@redking.me.uk wrote: RKSimon added a comment. Yes using that uninitialized value has worried me as well. I originally set it to zero (and considered using __ LINE __ or __ COUNTER __) but both introduce defined behaviour that I could see

Re: [PATCH] D12052: [X86][SSE] Add _mm_undefined_* intrinsics

2015-08-16 Thread Michael Kuperstein via cfe-commits
mkuper added a comment. Thanks, Simon! I've wanted to add the _undefined intrinsics for a while now, but never got to it. Anyway, this sort of implementation somewhat worries me. Yes, I know that the gcc intrinsics do something very similar. And I also know that in practice we'll get an undef

Re: [PATCH] D12052: [X86][SSE] Add _mm_undefined_* intrinsics

2015-08-16 Thread Simon Pilgrim via cfe-commits
RKSimon added a comment. Yes using that uninitialized value has worried me as well. I originally set it to zero (and considered using __ LINE __ or __ COUNTER __) but both introduce defined behaviour that I could see causing all sorts of problems further down the line in debug vs release

[PATCH] D12052: [X86][SSE] Add _mm_undefined_* intrinsics

2015-08-15 Thread Simon Pilgrim via cfe-commits
RKSimon created this revision. RKSimon added reviewers: craig.topper, echristo, mkuper. RKSimon added a subscriber: cfe-commits. RKSimon set the repository for this revision to rL LLVM. Adds missing SSE/AVX 'undefined' intrinsics (PR24040): _mm_undefined_pd + _mm256_undefined_pd _mm_undefined_ps