[PATCH] D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes

ldionne added inline comments. Comment at: clang/include/clang/Driver/Options.td:1186 -defm unstable : BoolFOption<"unstable", - LangOpts<"Unstable">, DefaultFalse, - PosFlag, +defm experimental_library : BoolFOption<"experimental-library", +

[PATCH] D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes

Mordante accepted this revision. Mordante added a comment. LGTM, but please update the name of the flag in the title before landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121141/new/ https://reviews.llvm.org/D121141

[PATCH] D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Herald added a subscriber: StephenFan. Comment at: clang/include/clang/Driver/Options.td:1186 -defm unstable : BoolFOption<"unstable", - LangOpts<"Unstable">,

[PATCH] D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes

ldionne updated this revision to Diff 444753. ldionne added a comment. Address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121141/new/ https://reviews.llvm.org/D121141 Files: clang/docs/ClangCommandLineReference.rst

[PATCH] D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes

ldionne marked an inline comment as done. ldionne added a comment. In D121141#3652616 , @MaskRay wrote: > LGTM. > > It may be related, @urnathan wants to add `-std=c++{current,future}` to GCC > and may have opinions on the option name. Interesting!

[PATCH] D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes

MaskRay added a subscriber: urnathan. MaskRay added a comment. LGTM. It may be related, @urnathan wants to add `-std=c++{current,future}` to GCC and may have opinions on the option name. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5840 - if

[PATCH] D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes

ldionne added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:276 + +Enable unstable and experimental language and library features. + MaskRay wrote: > The doc is auto-generated by tablegen >

[PATCH] D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes

ldionne updated this revision to Diff 444709. ldionne marked an inline comment as done. ldionne added a comment. Herald added subscribers: pmatos, asb, abrachet, atanasyan, jrtc27, aheejin, jgravelle-google, sbc100, sdardis, dschuff, emaste. - Rebase - Rename to -fexperimental-library - Add

[PATCH] D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes

MaskRay added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:276 + +Enable unstable and experimental language and library features. + The doc is auto-generated by tablegen

[PATCH] D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes

Mordante added a comment. Thanks @egorzhdan for working on this, I seem to have overlooked this item in the review queue. SGMT, but it seems the libc++ CI hasn't been triggered with this change. Maybe change one file in libc++ to give the CI a spin? Comment at:

[PATCH] D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes

ldionne commandeered this revision. ldionne edited reviewers, added: egorzhdan; removed: ldionne. ldionne added a comment. Herald added a subscriber: MaskRay. Thanks a lot for the fixes @egorzhdan! I think this looks pretty good. Since LLVM 15 is coming up and we'd like to have this in its final

[PATCH] D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes

egorzhdan created this revision. Herald added a subscriber: dang. Herald added a project: All. egorzhdan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a follow-up for https://reviews.llvm.org/D120160 that addresses some of the