[PATCH] D121150: [pseudo] Implement the GLR parsing algorithm.

2022-05-03 Thread Haojian Wu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeac22d0754f7: [pseudo] Implement the GLR parsing algorithm. (authored by sammccall, committed by hokein). Repository: rG LLVM Github Monorepo

[PATCH] D121150: [pseudo] Implement the GLR parsing algorithm.

2022-05-03 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 426680. hokein retitled this revision from "[pseudo] Implement the GLR parsing algorithm. " to "[pseudo] Implement the GLR parsing algorithm.". hokein added a comment. fix a dangling reference of the source text in clang-pseudo. Repository: rG LLVM

[PATCH] D121150: [pseudo] Implement the GLR parsing algorithm.

2022-05-03 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/GLR.h:143 +// parsing process (glrShift, or glrReduce). +using NewHeadCallback = +std::function nit: this is always used synchronously, so llvm::function_ref? we have a `captureNewHeads`