[PATCH] D121175: [clang] Add -Wstart-no-unknown-warning-option/-Wend-no-unknown-warning-option.

mysterymath abandoned this revision. mysterymath added a comment. Given that we didn't reach a consensus on this one, I'll abandon this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121175/new/ https://reviews.llvm.org/D121175

[PATCH] D121175: [clang] Add -Wstart-no-unknown-warning-option/-Wend-no-unknown-warning-option.

mstorsjo added a comment. In D121175#3486104 , @phosek wrote: > In D121175#3481547 , @MaskRay wrote: > >> Probably no from my view, as I got another internal feedback that "this >> seems rather crufty". >> It

[PATCH] D121175: [clang] Add -Wstart-no-unknown-warning-option/-Wend-no-unknown-warning-option.

phosek added a comment. In D121175#3481547 , @MaskRay wrote: > Probably no from my view, as I got another internal feedback that "this seems > rather crufty". > It seems that it is the build system maintainer's responsibility. If you add >

[PATCH] D121175: [clang] Add -Wstart-no-unknown-warning-option/-Wend-no-unknown-warning-option.

dblaikie added a comment. Would an explicit naming be more suitable than a region start/end? (I'd have considered this feedback for D116503 too, but didn't catch that one in review) The region based thing makes non-positional arguments weirdly positional (not

[PATCH] D121175: [clang] Add -Wstart-no-unknown-warning-option/-Wend-no-unknown-warning-option.

MaskRay added a comment. Probably no from my view, as I got another internal feedback that "this seems rather crufty". It seems that it is the build system maintainer's responsibility. If you add `-Wno-unknown-warning-option` temporarily, after a new clang is rolled, you may remove

[PATCH] D121175: [clang] Add -Wstart-no-unknown-warning-option/-Wend-no-unknown-warning-option.

mysterymath added a comment. Herald added a subscriber: StephenFan. Wanted to circle back around to this one, since this feature would still really help improve the workflow for ignoring warnings on build systems without deep compiler examination capabilities. Can we move forward with this?

[PATCH] D121175: [clang] Add -Wstart-no-unknown-warning-option/-Wend-no-unknown-warning-option.

phosek added a comment. In D121175#3372056 , @condy wrote: > IMHO, it's the duty of build systems. CMake provides > `check_cxx_compiler_flag` to report unknown options. That's only true for build systems that perform configure time checks like CMake,

[PATCH] D121175: [clang] Add -Wstart-no-unknown-warning-option/-Wend-no-unknown-warning-option.

MaskRay added a comment. I am also unsure about the usefulness. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121175/new/ https://reviews.llvm.org/D121175 ___ cfe-commits mailing list

[PATCH] D121175: [clang] Add -Wstart-no-unknown-warning-option/-Wend-no-unknown-warning-option.

condy added a comment. IMHO, it's the duty of build systems. CMake provides `check_cxx_compiler_flag` to report unknown options. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121175/new/ https://reviews.llvm.org/D121175

[PATCH] D121175: [clang] Add -Wstart-no-unknown-warning-option/-Wend-no-unknown-warning-option.

mysterymath created this revision. mysterymath added reviewers: phosek, MaskRay. Herald added a subscriber: dexonsmith. Herald added a project: All. mysterymath requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These options allow guarding a