hubert.reinterpretcast added inline comments.
Comment at: clang/test/CodeGen/PowerPC/atomic-alignment.c:1
+// REQUIRES: powerpc-registered-target
+// RUN: %clang_cc1 -verify -triple powerpc-unkonwn-unknown -emit-llvm -o - %s
| \
lkail wrote:
>
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9247145fbae7: [PowerPC][NFC] Add atomic alignments and ops
tests for powerpc (authored by lkail).
Repository:
rG LLVM Github Monorepo
CHANGES
lkail added inline comments.
Comment at: clang/test/CodeGen/PowerPC/atomic-alignment.c:1
+// REQUIRES: powerpc-registered-target
+// RUN: %clang_cc1 -verify -triple powerpc-unkonwn-unknown -emit-llvm -o - %s
| \
hubert.reinterpretcast wrote:
>
hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.
LGTM with comment (not blocking).
Comment at: clang/test/CodeGen/PowerPC/atomic-alignment.c:1
+// REQUIRES: powerpc-registered-target
+// RUN: %clang_cc1 -verify -triple
lkail updated this revision to Diff 415684.
lkail added a comment.
Fix typo; Add `pwr7` and `pwr8` as `-target-cpu`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121441/new/
https://reviews.llvm.org/D121441
Files:
hubert.reinterpretcast added inline comments.
Comment at: clang/test/CodeGen/PowerPC/atomic-alignment.c:1
+// REQUIRES: powerpc-registered-target
+// RUN: %clang_cc1 -verify -triple powerpc-unkonwn-unknown -emit-llvm -o - %s
| \
I am not sure about having a
hubert.reinterpretcast added inline comments.
Comment at: clang/test/CodeGen/PowerPC/atomic-alignment.c:2-6
+// RUN: %clang_cc1 -verify -triple powerpc-unkonwn-unknown -emit-llvm -o - %s
| \
+// RUN: FileCheck %s --check-prefixes=PPC,PPC32
+// RUN: %clang_cc1 -verify -triple
jsji accepted this revision as: jsji.
jsji added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121441/new/
https://reviews.llvm.org/D121441
lkail updated this revision to Diff 414583.
lkail added a comment.
Add `-verify`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121441/new/
https://reviews.llvm.org/D121441
Files:
clang/test/CodeGen/PowerPC/atomic-alignment.c
lkail updated this revision to Diff 414575.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121441/new/
https://reviews.llvm.org/D121441
Files:
clang/test/CodeGen/PowerPC/atomic-alignment.c
clang/test/Sema/atomic-ops.c
Index:
lkail updated this revision to Diff 414574.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121441/new/
https://reviews.llvm.org/D121441
Files:
clang/test/CodeGen/PowerPC/atomic-alignment.c
clang/test/Sema/atomic-ops.c
Index:
lkail created this revision.
lkail added reviewers: hubert.reinterpretcast, jsji, xingxue, PowerPC.
Herald added subscribers: steven.zhang, shchenz, nemanjai.
Herald added a project: All.
lkail requested review of this revision.
Herald added a project: clang.
Herald added a subscriber:
12 matches
Mail list logo