Re: [PATCH] D12148: [ARM] Allow passing/returning of __fp16 arguments

2015-09-03 Thread Renato Golin via cfe-commits
rengolin accepted this revision. rengolin added a reviewer: rengolin. rengolin added a comment. This revision is now accepted and ready to land. LGTM, thanks! http://reviews.llvm.org/D12148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12148: [ARM] Allow passing/returning of __fp16 arguments

2015-09-03 Thread Oliver Stannard via cfe-commits
olista01 closed this revision. olista01 added a comment. Thanks, committed as r246755. http://reviews.llvm.org/D12148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12148: [ARM] Allow passing/returning of __fp16 arguments

2015-09-03 Thread Oliver Stannard via cfe-commits
olista01 updated this revision to Diff 33932. olista01 added a comment. Don't make this change for OpenCL, which handles the half type natively. http://reviews.llvm.org/D12148 Files: lib/Basic/Targets.cpp lib/CodeGen/TargetInfo.cpp lib/Driver/Tools.cpp test/CodeGen/arm-fp16-arguments.c

Re: [PATCH] D12148: [ARM] Allow passing/returning of __fp16 arguments

2015-09-03 Thread Renato Golin via cfe-commits
rengolin added a comment. I don't like the idea of making it language-specific, but I don't have a better idea. I don't know if there are support flags in Clang's languages like we have for back-ends. Anyway, this should fix the current problem. Maybe adding a comment to that effect on the

Re: [PATCH] D12148: [ARM] Allow passing/returning of __fp16 arguments

2015-09-03 Thread Oliver Stannard via cfe-commits
olista01 added a comment. Committed as r246764, with an additional comment explaining why we don't do this for OpenCL. http://reviews.llvm.org/D12148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12148: [ARM] Allow passing/returning of __fp16 arguments

2015-09-01 Thread Oliver Stannard via cfe-commits
olista01 added a comment. Ping? http://reviews.llvm.org/D12148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12148: [ARM] Allow passing/returning of __fp16 arguments

2015-09-01 Thread James Molloy via cfe-commits
jmolloy added a comment. This looks alright to me, but I'd like to wait for someone more familiar with Clang to approve it. http://reviews.llvm.org/D12148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12148: [ARM] Allow passing/returning of __fp16 arguments

2015-08-24 Thread Oliver Stannard via cfe-commits
olista01 removed rL LLVM as the repository for this revision. olista01 updated this revision to Diff 32967. olista01 added a comment. Use a switch statement to check the target architecture. http://reviews.llvm.org/D12148 Files: lib/Basic/Targets.cpp lib/CodeGen/TargetInfo.cpp

[PATCH] D12148: [ARM] Allow passing/returning of __fp16 arguments

2015-08-19 Thread Oliver Stannard via cfe-commits
olista01 created this revision. olista01 added a subscriber: cfe-commits. olista01 set the repository for this revision to rL LLVM. Herald added subscribers: rengolin, aemerson. The ACLE (ARM C Language Extensions) 2.0 allows the __fp16 type to be used as a functon argument or return type (ACLE

Re: [PATCH] D12148: [ARM] Allow passing/returning of __fp16 arguments

2015-08-19 Thread James Molloy via cfe-commits
jmolloy added a subscriber: jmolloy. Comment at: lib/CodeGen/TargetInfo.cpp:4717 @@ -4716,1 +4716,3 @@ + // __fp16 gets passed as if it were an int or float, but with the top 32 bits + // unspecified. Top 16 bits? Comment at:

Re: [PATCH] D12148: [ARM] Allow passing/returning of __fp16 arguments

2015-08-19 Thread Oliver Stannard via cfe-commits
olista01 updated this revision to Diff 32558. olista01 added a comment. Fixed typo Repository: rL LLVM http://reviews.llvm.org/D12148 Files: lib/Basic/Targets.cpp lib/CodeGen/TargetInfo.cpp lib/Driver/Tools.cpp test/CodeGen/arm-fp16-arguments.c test/Preprocessor/arm-acle-6.5.c