This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG407c721ceb93: [Support] Change zlib::compress to return void
(authored by MaskRay).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
ikudrin accepted this revision.
ikudrin added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121512/new/
https://reviews.llvm.org/D121512
_
MaskRay updated this revision to Diff 415167.
MaskRay marked an inline comment as done.
MaskRay added a comment.
Simplify CompressedSection::CompressedSection in llvm-objcopy.
CompressedSection::create can be further simplified, but I'll leave that as a
future change.
Repository:
rG LLVM Git
ikudrin added inline comments.
Comment at: llvm/lib/ObjCopy/ELF/ELFObject.cpp:568
DebugCompressionType CompressionType,
Error &OutErr)
: SectionBase(Sec), CompressionType(CompressionType),
--
joerg added a comment.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121512/new/
https://reviews.llvm.org/D121512
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
MaskRay updated this revision to Diff 414896.
MaskRay retitled this revision from "[Support] zlib::compress: replace
compress2 with iterative deflate" to "[Support] Change zlib::compress to return
void".
MaskRay edited the summary of this revision.
MaskRay added a comment.
Herald added subscriber
