[PATCH] D121549: Define ABI breaking class members correctly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf854434f0f2a: [NVPTX] Enhance vectorization of ld.param st.param (authored by kovdan01). Herald added subscribers: asavonic, StephenFan,

[PATCH] D121549: Define ABI breaking class members correctly

dexonsmith accepted this revision. dexonsmith added a comment. LGTM too; thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121549/new/ https://reviews.llvm.org/D121549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D121549: Define ABI breaking class members correctly

kovdan01 updated this revision to Diff 415049. kovdan01 marked an inline comment as done. kovdan01 removed projects: MLIR, clang. kovdan01 added a comment. Fix formatting problems found on pre-merge checks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121549/new/

[PATCH] D121549: Define ABI breaking class members correctly

mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121549/new/ https://reviews.llvm.org/D121549 ___ cfe-commits mailing list

[PATCH] D121549: Define ABI breaking class members correctly

kovdan01 marked an inline comment as done. kovdan01 added inline comments. Comment at: mlir/lib/Target/SPIRV/Deserialization/Deserializer.h:601 + // TODO: place logger under #if LLVM_ENABLE_ABI_BREAKING_CHECKS #ifndef NDEBUG mehdi_amini wrote: > This is a

[PATCH] D121549: Define ABI breaking class members correctly

kovdan01 updated this revision to Diff 415022. kovdan01 added a comment. Keep private headers untouched CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121549/new/ https://reviews.llvm.org/D121549 Files: llvm/include/llvm/CodeGen/GlobalISel/GISelWorkList.h

[PATCH] D121549: Define ABI breaking class members correctly

mehdi_amini added inline comments. Comment at: mlir/lib/Target/SPIRV/Deserialization/Deserializer.h:601 + // TODO: place logger under #if LLVM_ENABLE_ABI_BREAKING_CHECKS #ifndef NDEBUG This is a private header (you're in the `lib` directory and not in the

[PATCH] D121549: Define ABI breaking class members correctly

kovdan01 updated this revision to Diff 414929. kovdan01 added a comment. Fix typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121549/new/ https://reviews.llvm.org/D121549 Files: clang/lib/Sema/TypeLocBuilder.cpp clang/lib/Sema/TypeLocBuilder.h

[PATCH] D121549: Define ABI breaking class members correctly

kovdan01 created this revision. kovdan01 added reviewers: dexonsmith, craig.topper. Herald added subscribers: sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, ThomasRaoux, msifontes, ecnelises, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik,