[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp reopened this revision. quinnp added a comment. This revision is now accepted and ready to land. Re-opening the revision so that I can update it with a fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121637/new/

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp added a comment. In D121637#3437371 , @thakis wrote: > Looks like this breaks tests on windows: > http://45.33.8.238/win/55893/step_7.txt > > Please take a look and revert for now if it takes a while to fix. Thanks for finding this, not sure

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/55893/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121637/new/

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2aae5b1fac38: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp updated this revision to Diff 421303. quinnp added a comment. Fixing a set of builtins added by the rebase with main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121637/new/ https://reviews.llvm.org/D121637 Files:

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp updated this revision to Diff 421286. quinnp added a comment. Rebasing with main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121637/new/ https://reviews.llvm.org/D121637 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15627 +Value *Y = +Builder.CreateAnd(EmitScalarExpr(E->getArg(1)), Builder.CreateNot(Op3)); return Builder.CreateOr(X, Y); nemanjai wrote: > Nit: I understand that we

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp updated this revision to Diff 421279. quinnp marked an inline comment as done. quinnp added a comment. Fixing some testcases that broke due to re-ordering IR in my last update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121637/new/

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

nemanjai accepted this revision. nemanjai added a comment. Please add a test case that would cause a failure prior to this patch due to the argument being emitted more than once (i.e. the test case that prompted this patch). If that is already added and I just missed it, please add a note to

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

amyk accepted this revision as: amyk. amyk added a comment. This revision is now accepted and ready to land. Thanks Quinn. i think this overall LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121637/new/ https://reviews.llvm.org/D121637

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp marked an inline comment as done. quinnp added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15208 - for (unsigned i = 0, e = E->getNumArgs(); i != e; i++) { -if (E->getArg(i)->getType()->isArrayType()) -

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp updated this revision to Diff 419126. quinnp added a comment. Moving testcases that require code generation from `clang/test/Sema/ppc-pair-mma-types.c` to `clang/test/CodeGen/PowerPC/ppc-mma-types.c` and `clang/test/CodeGen/PowerPC/builtins-ppc-pair-mma-types.c`. This is because some

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15208 - for (unsigned i = 0, e = E->getNumArgs(); i != e; i++) { -if (E->getArg(i)->getType()->isArrayType()) - Ops.push_back(EmitArrayToPointerDecay(E->getArg(i)).getPointer());

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

amyk added a comment. Overall this change looks good to me, although I do have one question. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15208 - for (unsigned i = 0, e = E->getNumArgs(); i != e; i++) { -if (E->getArg(i)->getType()->isArrayType()) -

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp updated this revision to Diff 416917. quinnp added a comment. Fixing a failing test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121637/new/ https://reviews.llvm.org/D121637 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp updated this revision to Diff 415412. quinnp added a comment. Minor formatting update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121637/new/ https://reviews.llvm.org/D121637 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. Herald added a project: All. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch refactors `EmitPPCBuiltinExpr` in `CGBuiltin.cpp` to remove